Update rfc2136 provider to split out changes per zone

[gregsidelinger]

Description
Update the rfc2136 provider to update each zone separately as the current implantation causes errors if the change spans zones.

Fixes #4106

Checklist

• Unit tests updated
• End user documentation updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: gregsidelinger / name: Greg (e44aa65, e3b8e54, 1418a3a, 7427c8e, 35dc1fc, 2b4aa56, 8e9a416)

[k8s-ci-robot]

Hi @gregsidelinger. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mloiseleur]

This PR needs a test case, to reproduce this issue and ensure the fix will continue to work.

[gregsidelinger]

@mloiseleur I have some ideas how to test for this. It will be a few days before I get around to mocking something out but I will update the test cases.

[gregsidelinger]

@mloiseleur I added some different test cases. Most of the test cases I added was around things that here not being tested before. I'm actually testing the test version of SendMessage to make sure it does not receive a multizone change, except for the root zone as I needed to update my change to address that.

[mloiseleur]

It's looking good, thanks. I'll wait that you have finished for a complete review.
Would you please also update PR's description (first line) ? :)
/ok-to-test

[gregsidelinger]

I think I figured out why the test suite is failing. The order of the createMsgs and other objects updated by the stubbed version of SendMessage is not fixed as I loop over map which is not an ordered object. Will get the suite updated shortly to address.

[gregsidelinger]

@mloiseleur how is the PR looking now that I extended the test suite?

[mloiseleur]

Suggested change

	log.Errorf("RFC2136 update failed: %v", err)
	log.Errorf("RFC2136 create record failed: %v", err)

[mloiseleur]

Suggested change

	log.Errorf("RFC2136 update failed: %v", err)
	log.Errorf("RFC2136 delete record failed: %v", err)

[mloiseleur]

Suggested change

	log.Errorf("RFC2136 update failed: %v", err)
	log.Errorf("RFC2136 update record failed: %v", err)

[mloiseleur]

Suggested change

	err := r.actions.SendMessage(z)
	if err != nil {
	if err := r.actions.SendMessage(z); err != nil {

[mloiseleur]

Suggested change

	err := r.actions.SendMessage(z)
	if err != nil {
	if err := r.actions.SendMessage(z); err != nil {

[mloiseleur]

Suggested change

	err := r.actions.SendMessage(z)
	if err != nil {
	if err := r.actions.SendMessage(z); err != nil {

[mloiseleur]

It looks good to me. I have just minor suggestion.

[gregsidelinger]

Ok, suggestions are in there as well as one other log msg update to make them all consistent. And the linter check finally passed after getting kicked.

[mloiseleur]

/lgtm

[szuecs]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [szuecs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment