fix(pdns): provider implicitly changes CNAME to ALIAS #4162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: no
|
Welcome @tmaroschik! |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @tmaroschik. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
size/M
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
mloiseleur
reviewed
Jan 9, 2024
|
Thanks for this PR. It looks good and it's well tested. |
k8s-ci-robot
added
lgtm
mloiseleur
reviewed
Jan 10, 2024
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
tmaroschik
force-pushed
the
fix/pdns-converts-cname-to-alias
branch
from
cefc2cb
to
99b7abd
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: szuecs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
truecharts-admin
added a commit
to truecharts/charts
that referenced
this pull request
Mar 22, 2024
…rnal-dns to v0.14.1@7bb4c52 by renovate (#19644) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [registry.k8s.io/external-dns/external-dns](https://github.com/kubernetes-sigs/external-dns) | patch | `v0.14.0` -> `v0.14.1` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes-sigs/external-dns (registry.k8s.io/external-dns/external-dns)</summary> ### [`v0.14.1`](https://github.com/kubernetes-sigs/external-dns/releases/tag/v0.14.1) [Compare Source](https://github.com/kubernetes-sigs/external-dns/compare/v0.14.0...v0.14.1) #### What's Changed - docs: add reference to adguard webhook provider by [@​muhlba91](https://github.com/muhlba91) in [kubernetes-sigs/external-dns#4030 - Update azure.md by [@​sesoldi](https://github.com/sesoldi) in [kubernetes-sigs/external-dns#4009 - add initial support for gw apis 1.0.0 GA by [@​larivierec](https://github.com/larivierec) in [kubernetes-sigs/external-dns#4019 - build(deps): bump the dev-dependencies group with 3 updates by [@​dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4028 - add stackit webhook to readme by [@​PatrickKoss](https://github.com/PatrickKoss) in [kubernetes-sigs/external-dns#4029 - Add org.opencontainers.image.source label to container image by [@​robinschneider](https://github.com/robinschneider) in [kubernetes-sigs/external-dns#4022 - bump kustomize version to v0.14.0 by [@​Raffo](https://github.com/Raffo) in [kubernetes-sigs/external-dns#4024 - OCI Provider private zone and workload identity support by [@​anders-swanson](https://github.com/anders-swanson) in [kubernetes-sigs/external-dns#3995 - RFC2136: Allow multiple zones by [@​CRASH-Tech](https://github.com/CRASH-Tech) in [kubernetes-sigs/external-dns#3976 - chore(chart): Updated GH workflows by [@​stevehipwell](https://github.com/stevehipwell) in [kubernetes-sigs/external-dns#4010 - fix: dynamodb registry when statements over 25 by [@​danie1sullivan](https://github.com/danie1sullivan) in [kubernetes-sigs/external-dns#4021 - Allow to configure revisionHistoryLimit on the K8s Deployment resource by [@​arnisoph](https://github.com/arnisoph) in [kubernetes-sigs/external-dns#4008 - chore: Bump kingpin/v2 dep by [@​mrueg](https://github.com/mrueg) in [kubernetes-sigs/external-dns#4033 - Update all image versions in documentation by [@​Raffo](https://github.com/Raffo) in [kubernetes-sigs/external-dns#4037 - updated various broken link in ultradns tutorial by [@​kundan2707](https://github.com/kundan2707) in [kubernetes-sigs/external-dns#3794 - Make --ignore-hostname-annotation flag more consistent by [@​johngmyers](https://github.com/johngmyers) in [kubernetes-sigs/external-dns#3964 - service source uses externalIPs in ExternalName type if available by [@​dromie](https://github.com/dromie) in [kubernetes-sigs/external-dns#4007 - build(deps): bump the dev-dependencies group with 1 update by [@​dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4046 - fix(google): ensure trailing dot for SRV records by [@​siliconsheep](https://github.com/siliconsheep) in [kubernetes-sigs/external-dns#4048 - oracle provider: dns zone cache by [@​anders-swanson](https://github.com/anders-swanson) in [kubernetes-sigs/external-dns#4049 - fix(httpProxy): drop status==valid filter by [@​nefelim4ag](https://github.com/nefelim4ag) in [kubernetes-sigs/external-dns#3978 - doc: added --infoblox-view argument to Infoblox documentation by [@​tanerm](https://github.com/tanerm) in [kubernetes-sigs/external-dns#4036 - fix: regression on scaleway provider in 0.14.0 by [@​M0NsTeRRR](https://github.com/M0NsTeRRR) in [kubernetes-sigs/external-dns#4039 - Add GleSYS to the readme for webhooks by [@​glesys-andreas](https://github.com/glesys-andreas) in [kubernetes-sigs/external-dns#4054 - build(deps): bump the dev-dependencies group with 1 update by [@​dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4057 - feat: make webhook httpapi reusable by [@​mrueg](https://github.com/mrueg) in [kubernetes-sigs/external-dns#4065 - Make routegroup client IPv6 compatible by [@​mikkeloscar](https://github.com/mikkeloscar) in [kubernetes-sigs/external-dns#4068 - doc: fix link to ionos webhook provider by [@​akrieg-ionos](https://github.com/akrieg-ionos) in [kubernetes-sigs/external-dns#4031 - feat(chart): Added complex provider support by [@​stevehipwell](https://github.com/stevehipwell) in [kubernetes-sigs/external-dns#4085 - chore: update 45 go modules dependancies by [@​mloiseleur](https://github.com/mloiseleur) in [kubernetes-sigs/external-dns#4088 - webhook: Move httpapi into own package by [@​mrueg](https://github.com/mrueg) in [kubernetes-sigs/external-dns#4084 - doc: Add netcup webhook provider by [@​mrueg](https://github.com/mrueg) in [kubernetes-sigs/external-dns#4095 - build(deps): bump the dev-dependencies group with 3 updates by [@​dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4097 - update to add il-central-1 by [@​theloneexplorerquest](https://github.com/theloneexplorerquest) in [kubernetes-sigs/external-dns#4093 - Add readme bizflycloud webhook provider by [@​huyduong2792](https://github.com/huyduong2792) in [kubernetes-sigs/external-dns#4079 - fix: Allow revisionHistoryLimit to be set to 0 by [@​bodgit](https://github.com/bodgit) in [kubernetes-sigs/external-dns#4053 - helm: Avoid unnecessary pod restart on each helm chart version by [@​jkroepke](https://github.com/jkroepke) in [kubernetes-sigs/external-dns#4103 - Correct typo from 'Kuberntes' to 'Kubernetes' by [@​jongwooo](https://github.com/jongwooo) in [kubernetes-sigs/external-dns#4118 - build(deps): bump golang.org/x/crypto from 0.16.0 to 0.17.0 by [@​dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4123 - cleanup: remove dead code (`(Create|Update|Delete)Records` functions in AWS, Google, DNSimple) by [@​mloiseleur](https://github.com/mloiseleur) in [kubernetes-sigs/external-dns#4129 - ci: remove `confusing-naming` property by [@​PascalBourdier](https://github.com/PascalBourdier) in [kubernetes-sigs/external-dns#4116 - chore: fix code comment by [@​tanujd11](https://github.com/tanujd11) in [kubernetes-sigs/external-dns#4131 - fix: include cloudflare error in metrics and logs by [@​danie1sullivan](https://github.com/danie1sullivan) in [kubernetes-sigs/external-dns#4082 - gateway-api: fix wildcard matching by [@​abursavich](https://github.com/abursavich) in [kubernetes-sigs/external-dns#4124 - build(deps): bump the dev-dependencies group with 23 updates by [@​dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4134 - Hetzner webhook provider readme link by [@​mconfalonieri](https://github.com/mconfalonieri) in [kubernetes-sigs/external-dns#4051 - Fix timeout for traefik-proxy source by [@​k8r-io](https://github.com/k8r-io) in [kubernetes-sigs/external-dns#4076 - build(deps): bump the dev-dependencies group with 7 updates by [@​dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4144 - fix: remove useless functions by [@​PascalBourdier](https://github.com/PascalBourdier) in [kubernetes-sigs/external-dns#4115 - fix(ambassador): don't resolve LB hostname by [@​fad3t](https://github.com/fad3t) in [kubernetes-sigs/external-dns#4092 - doc(azure): shows how to use userAssignedIdentityID with clientId in azure.json by [@​thesse1](https://github.com/thesse1) in [kubernetes-sigs/external-dns#4133 - build(deps): bump the dev-dependencies group with 4 updates by [@​dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4146 - webhook: Fix metric name and add request gauges by [@​mrueg](https://github.com/mrueg) in [kubernetes-sigs/external-dns#4078 - build(deps): bump the dev-dependencies group with 2 updates by [@​dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4145 - build(deps): bump the dev-dependencies group with 1 update by [@​dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4154 - fix: heritage txt record was not able to be created for txt record by [@​tanujd11](https://github.com/tanujd11) in [kubernetes-sigs/external-dns#4140 - build(deps): bump the dev-dependencies group with 9 updates by [@​dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4155 - fix(istio): support for ExternalIPs in Istio resources by [@​KarstenSiemer](https://github.com/KarstenSiemer) in [kubernetes-sigs/external-dns#4094 - Update rfc2136 provider to split out changes per zone by [@​gregsidelinger](https://github.com/gregsidelinger) in [kubernetes-sigs/external-dns#4107 - Exoscale provider optimization by [@​kobajagi](https://github.com/kobajagi) in [kubernetes-sigs/external-dns#4071 - fix: godaddy - rate limiter add one token every second by [@​nefelim4ag](https://github.com/nefelim4ag) in [kubernetes-sigs/external-dns#4087 - feat(helm-chart): Allow configuration of ipFamilyPolicy by [@​dongjiang1989](https://github.com/dongjiang1989) in [kubernetes-sigs/external-dns#4153 - chore(chart): Deprecated secretConfiguration by [@​stevehipwell](https://github.com/stevehipwell) in [kubernetes-sigs/external-dns#4161 - feat: support webhook provider in Chart by [@​mloiseleur](https://github.com/mloiseleur) in [kubernetes-sigs/external-dns#4032 - feat(helm-chart): Released chart for v0.14.0 by [@​appkins](https://github.com/appkins) in [kubernetes-sigs/external-dns#4073 - chore(chart): Fixed chart changelog by [@​stevehipwell](https://github.com/stevehipwell) in [kubernetes-sigs/external-dns#4168 - fix(pdns): provider implicitly changes CNAME to ALIAS by [@​tmaroschik](https://github.com/tmaroschik) in [kubernetes-sigs/external-dns#4162 - fix(chart): Fix webhook install failure by [@​gabe565](https://github.com/gabe565) in [kubernetes-sigs/external-dns#4173 - fix: provide possibility to have a soft error mode by [@​szuecs](https://github.com/szuecs) in [kubernetes-sigs/external-dns#4166 - \[helm] Allow tpl in provider again by [@​jkroepke](https://github.com/jkroepke) in [kubernetes-sigs/external-dns#4180 - Fix args for webhook deployment by [@​webwurst](https://github.com/webwurst) in [kubernetes-sigs/external-dns#4202 - add RBAC fix to namespaces - get, watch, list to each gateway-\*route by [@​orenlevi111](https://github.com/orenlevi111) in [kubernetes-sigs/external-dns#4205 - chore: Released chart v1.14.3 by [@​stevehipwell](https://github.com/stevehipwell) in [kubernetes-sigs/external-dns#4208 - build(deps): bump the dev-dependencies group with 24 updates by [@​dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4227 - Fix "workload identity" spelling by [@​gdubicki](https://github.com/gdubicki) in [kubernetes-sigs/external-dns#4201 - feat(aws-provider): create flag to support sub-domains match parent by [@​thiagoluiznunes](https://github.com/thiagoluiznunes) in [kubernetes-sigs/external-dns#4236 - Change coredns testing to fix failing tests by [@​pascalgn](https://github.com/pascalgn) in [kubernetes-sigs/external-dns#4245 - Validate AWS record values size during batch set generation by [@​megum1n](https://github.com/megum1n) in [kubernetes-sigs/external-dns#4126 - build(deps): bump the dev-dependencies group with 1 update by [@​dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4222 - build(deps): bump the dev-dependencies group with 13 updates by [@​dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4246 - Update link to current workshop by [@​AndrewCharlesHay](https://github.com/AndrewCharlesHay) in [kubernetes-sigs/external-dns#4170 - cleanup: Drop additional docker files by [@​mrueg](https://github.com/mrueg) in [kubernetes-sigs/external-dns#4182 - chore: update the slack channel URL into the github support template by [@​angegar](https://github.com/angegar) in [kubernetes-sigs/external-dns#3815 - add soft error by [@​jeanfrancoislelezec](https://github.com/jeanfrancoislelezec) in [kubernetes-sigs/external-dns#4199 - Fix Gateway API TLS TCP Route by [@​zs-ko](https://github.com/zs-ko) in [kubernetes-sigs/external-dns#4213 - Update the OCI Provider to incorporate SoftError to avoid CrashLoopBackoff by [@​jrosinsk](https://github.com/jrosinsk) in [kubernetes-sigs/external-dns#4229 - Add Gcore provider on readme by [@​kokizzu](https://github.com/kokizzu) in [kubernetes-sigs/external-dns#4256 - feat: enable Azure subscription ID override by [@​pascalgn](https://github.com/pascalgn) in [kubernetes-sigs/external-dns#4186 - build(deps): bump the dev-dependencies group with 1 update by [@​dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4254 - feat: allow setting dnsConfig by [@​davhdavh](https://github.com/davhdavh) in [kubernetes-sigs/external-dns#4265 - build(deps): bump the dev-dependencies group with 17 updates by [@​dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4270 - build(deps): bump the dev-dependencies group with 1 update by [@​dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4269 - build(deps): bump the dev-dependencies group with 6 updates by [@​dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4279 - docs: 📝 add Azure DNS w/workload identity blog post to readme by [@​krukowskid](https://github.com/krukowskid) in [kubernetes-sigs/external-dns#4248 - feat(gandi): add support for personal access token by [@​deadlybore](https://github.com/deadlybore) in [kubernetes-sigs/external-dns#4249 - RFC2136: Add support for DNS-over-TLS by [@​iteratee](https://github.com/iteratee) in [kubernetes-sigs/external-dns#3974 - Fixing NAPTR support by [@​jstudler](https://github.com/jstudler) in [kubernetes-sigs/external-dns#4212 - doc: explain how to use Azure internal load balancer by [@​mloiseleur](https://github.com/mloiseleur) in [kubernetes-sigs/external-dns#4252 - fix(aws): allow alias records to be created when using the alias annotation by [@​papayakiwi](https://github.com/papayakiwi) in [kubernetes-sigs/external-dns#4178 - fix(service): omit nil endpoints and prefer endpointsForHostname() by [@​yurrriq](https://github.com/yurrriq) in [kubernetes-sigs/external-dns#4293 - chore: update maintainers by [@​mloiseleur](https://github.com/mloiseleur) in [kubernetes-sigs/external-dns#4304 - build(deps): bump the dev-dependencies group with 21 updates by [@​dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4307 - build(deps): bump the dev-dependencies group with 6 updates by [@​dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4312 - feat(ambassador): add support for provider specific annotations by [@​fad3t](https://github.com/fad3t) in [kubernetes-sigs/external-dns#4120 - build(deps): bump the dev-dependencies group with 8 updates by [@​dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4313 - build(deps): bump the dev-dependencies group with 2 updates by [@​dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4314 - build(deps): bump the dev-dependencies group with 14 updates by [@​dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4321 #### Docker image registry.k8s.io/external-dns/external-dns:v0.14.0 #### New Contributors - [@​muhlba91](https://github.com/muhlba91) made their first contribution in [kubernetes-sigs/external-dns#4030 - [@​sesoldi](https://github.com/sesoldi) made their first contribution in [kubernetes-sigs/external-dns#4009 - [@​larivierec](https://github.com/larivierec) made their first contribution in [kubernetes-sigs/external-dns#4019 - [@​PatrickKoss](https://github.com/PatrickKoss) made their first contribution in [kubernetes-sigs/external-dns#4029 - [@​robinschneider](https://github.com/robinschneider) made their first contribution in [kubernetes-sigs/external-dns#4022 - [@​anders-swanson](https://github.com/anders-swanson) made their first contribution in [kubernetes-sigs/external-dns#3995 - [@​CRASH-Tech](https://github.com/CRASH-Tech) made their first contribution in [kubernetes-sigs/external-dns#3976 - [@​danie1sullivan](https://github.com/danie1sullivan) made their first contribution in [kubernetes-sigs/external-dns#4021 - [@​arnisoph](https://github.com/arnisoph) made their first contribution in [kubernetes-sigs/external-dns#4008 - [@​dromie](https://github.com/dromie) made their first contribution in [kubernetes-sigs/external-dns#4007 - [@​siliconsheep](https://github.com/siliconsheep) made their first contribution in [kubernetes-sigs/external-dns#4048 - [@​tanerm](https://github.com/tanerm) made their first contribution in [kubernetes-sigs/external-dns#4036 - [@​glesys-andreas](https://github.com/glesys-andreas) made their first contribution in [kubernetes-sigs/external-dns#4054 - [@​akrieg-ionos](https://github.com/akrieg-ionos) made their first contribution in [kubernetes-sigs/external-dns#4031 - [@​theloneexplorerquest](https://github.com/theloneexplorerquest) made their first contribution in [kubernetes-sigs/external-dns#4093 - [@​huyduong2792](https://github.com/huyduong2792) made their first contribution in [kubernetes-sigs/external-dns#4079 - [@​tanujd11](https://github.com/tanujd11) made their first contribution in [kubernetes-sigs/external-dns#4131 - [@​mconfalonieri](https://github.com/mconfalonieri) made their first contribution in [kubernetes-sigs/external-dns#4051 - [@​k8r-io](https://github.com/k8r-io) made their first contribution in [kubernetes-sigs/external-dns#4076 - [@​thesse1](https://github.com/thesse1) made their first contribution in [kubernetes-sigs/external-dns#4133 - [@​dongjiang1989](https://github.com/dongjiang1989) made their first contribution in [kubernetes-sigs/external-dns#4153 - [@​appkins](https://github.com/appkins) made their first contribution in [kubernetes-sigs/external-dns#4073 - [@​tmaroschik](https://github.com/tmaroschik) made their first contribution in [kubernetes-sigs/external-dns#4162 - [@​gabe565](https://github.com/gabe565) made their first contribution in [kubernetes-sigs/external-dns#4173 - [@​webwurst](https://github.com/webwurst) made their first contribution in [kubernetes-sigs/external-dns#4202 - [@​orenlevi111](https://github.com/orenlevi111) made their first contribution in [kubernetes-sigs/external-dns#4205 - [@​gdubicki](https://github.com/gdubicki) made their first contribution in [kubernetes-sigs/external-dns#4201 - [@​thiagoluiznunes](https://github.com/thiagoluiznunes) made their first contribution in [kubernetes-sigs/external-dns#4236 - [@​AndrewCharlesHay](https://github.com/AndrewCharlesHay) made their first contribution in [kubernetes-sigs/external-dns#4170 - [@​angegar](https://github.com/angegar) made their first contribution in [kubernetes-sigs/external-dns#3815 - [@​jeanfrancoislelezec](https://github.com/jeanfrancoislelezec) made their first contribution in [kubernetes-sigs/external-dns#4199 - [@​zs-ko](https://github.com/zs-ko) made their first contribution in [kubernetes-sigs/external-dns#4213 - [@​kokizzu](https://github.com/kokizzu) made their first contribution in [kubernetes-sigs/external-dns#4256 - [@​davhdavh](https://github.com/davhdavh) made their first contribution in [kubernetes-sigs/external-dns#4265 - [@​krukowskid](https://github.com/krukowskid) made their first contribution in [kubernetes-sigs/external-dns#4248 - [@​deadlybore](https://github.com/deadlybore) made their first contribution in [kubernetes-sigs/external-dns#4249 - [@​iteratee](https://github.com/iteratee) made their first contribution in [kubernetes-sigs/external-dns#3974 - [@​jstudler](https://github.com/jstudler) made their first contribution in [kubernetes-sigs/external-dns#4212 - [@​papayakiwi](https://github.com/papayakiwi) made their first contribution in [kubernetes-sigs/external-dns#4178 - [@​yurrriq](https://github.com/yurrriq) made their first contribution in [kubernetes-sigs/external-dns#4293 **Full Changelog**: kubernetes-sigs/external-dns@v0.14.0...v0.14.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI2NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3970
The PR #3338 introduces a broken behavior, where a CNAME is converted to an ALIAS if the target doesn't match its zone, which doesn't make sense in terms of DNS. The scenario that @epollia describes, is about the limitation of DNS, that limits the use of CNAMEs to subdomains only. Only A and AAAA are allowed for the apex (simply speaking). For this reason, pdns supports the custom ALIAS record type, which resolves the target on the server instead of the client.
This change ensures the auto-conversion of CNAME to ALIAS on the domain apex, and removes the superflous target dependant conversion.
Checklist