fix: duplicated endpoint per hosted zone #4296

leonardocaylent · 2024-03-03T08:12:28Z

Description

Looking into Issue #4241 we found that Delete was trying to generate 2 calls with 6 records per hosted zone instead of 2 calls with 3 records each. Taking a deeper look, changes.Delete at plan.go was handling duplicates at 0.13.6 but on the latest version it's not filtering them anymore.
Removing the duplicate endpoints in plan.go solves this issue for all providers

Short explain of new behavior
Added a new function RemoveDuplicates to detect duplicated endpoints when needed
Added Unit Tests for the function
Removed duplicated records on plan.go for changes.Delete

Details
Create behavior:
Without the fix:

level=debug msg="Adding testdeploy.internal.sandbox.yourdomain.com. to zone internal.sandbox.yourdomain.com. [Id: /hostedzone/HZ2]"
level=debug msg="Adding testdeploy.internal.sandbox.yourdomain.com. to zone sandbox.yourdomain.com. [Id: /hostedzone/HZ1]"
level=debug msg="Adding testdeploy.internal.sandbox.yourdomain.com. to zone internal.sandbox.yourdomain.com. [Id: /hostedzone/HZ2]"
level=debug msg="Adding testdeploy.internal.sandbox.yourdomain.com. to zone sandbox.yourdomain.com. [Id: /hostedzone/HZ1]"
level=debug msg="Adding cname-testdeploy.internal.sandbox.yourdomain.com. to zone internal.sandbox.yourdomain.com. [Id: /hostedzone/HZ2]"
level=debug msg="Adding cname-testdeploy.internal.sandbox.yourdomain.com. to zone sandbox.yourdomain.com. [Id: /hostedzone/HZ1]"
level=info msg="Desired change: CREATE cname-testdeploy.internal.sandbox.yourdomain.com TXT [Id: /hostedzone/HZ2]"
level=info msg="Desired change: CREATE testdeploy.internal.sandbox.yourdomain.com A [Id: /hostedzone/HZ2]"
level=info msg="Desired change: CREATE testdeploy.internal.sandbox.yourdomain.com TXT [Id: /hostedzone/HZ2]"
level=info msg="3 record(s) in zone internal.sandbox.yourdomain.com. [Id: /hostedzone/HZ2] were successfully updated"
level=info msg="Desired change: CREATE cname-testdeploy.internal.sandbox.yourdomain.com TXT [Id: /hostedzone/HZ1]"
level=info msg="Desired change: CREATE testdeploy.internal.sandbox.yourdomain.com A [Id: /hostedzone/HZ1]"
level=info msg="Desired change: CREATE testdeploy.internal.sandbox.yourdomain.com TXT [Id: /hostedzone/HZ1]"
level=info msg="3 record(s) in zone sandbox.yourdomain.com. [Id: /hostedzone/HZ1] were successfully updated"

With the fix:

level=info msg="Desired change: CREATE cname-testdeploy.internal.sandbox.yourdomain.com TXT [Id: /hostedzone/HZ2]"
level=info msg="Desired change: CREATE testdeploy.internal.sandbox.yourdomain.com A [Id: /hostedzone/HZ2]"
level=info msg="Desired change: CREATE testdeploy.internal.sandbox.yourdomain.com TXT [Id: /hostedzone/HZ2]"
level=info msg="3 record(s) in zone internal.sandbox.yourdomain.com. [Id: /hostedzone/HZ2] were successfully updated"
level=info msg="Desired change: CREATE cname-testdeploy.internal.sandbox.yourdomain.com TXT [Id: /hostedzone/HZ1]"
level=info msg="Desired change: CREATE testdeploy.internal.sandbox.yourdomain.com A [Id: /hostedzone/HZ1]"
level=info msg="Desired change: CREATE testdeploy.internal.sandbox.yourdomain.com TXT [Id: /hostedzone/HZ1]"

Delete behavior:
Without the fix:

level=debug msg="Considering zone: /hostedzone/HZ1 (domain: sandbox.yourdomain.com.)"
level=debug msg="Considering zone: /hostedzone/HZ2 (domain: internal.sandbox.yourdomain.com.)"
level=debug msg="Adding testdeploy.internal.sandbox.yourdomain.com. to zone internal.sandbox.yourdomain.com. [Id: /hostedzone/HZ2]"
level=debug msg="Adding testdeploy.internal.sandbox.yourdomain.com. to zone sandbox.yourdomain.com. [Id: /hostedzone/HZ1]"
level=debug msg="Adding testdeploy.internal.sandbox.yourdomain.com. to zone internal.sandbox.yourdomain.com. [Id: /hostedzone/HZ2]"
level=debug msg="Adding testdeploy.internal.sandbox.yourdomain.com. to zone sandbox.yourdomain.com. [Id: /hostedzone/HZ1]"
level=debug msg="Adding testdeploy.internal.sandbox.yourdomain.com. to zone internal.sandbox.yourdomain.com. [Id: /hostedzone/HZ2]"
level=debug msg="Adding testdeploy.internal.sandbox.yourdomain.com. to zone sandbox.yourdomain.com. [Id: /hostedzone/HZ1]"
level=debug msg="Adding cname-testdeploy.internal.sandbox.yourdomain.com. to zone internal.sandbox.yourdomain.com. [Id: /hostedzone/HZ2]"
level=debug msg="Adding cname-testdeploy.internal.sandbox.yourdomain.com. to zone sandbox.yourdomain.com. [Id: /hostedzone/HZ1]"
level=debug msg="Adding testdeploy.internal.sandbox.yourdomain.com. to zone internal.sandbox.yourdomain.com. [Id: /hostedzone/HZ2]"
level=debug msg="Adding testdeploy.internal.sandbox.yourdomain.com. to zone sandbox.yourdomain.com. [Id: /hostedzone/HZ1]"
level=debug msg="Adding cname-testdeploy.internal.sandbox.yourdomain.com. to zone internal.sandbox.yourdomain.com. [Id: /hostedzone/HZ2]"
level=debug msg="Adding cname-testdeploy.internal.sandbox.yourdomain.com. to zone sandbox.yourdomain.com. [Id: /hostedzone/HZ1]"
level=info msg="Desired change: DELETE cname-testdeploy.internal.sandbox.yourdomain.com TXT [Id: /hostedzone/HZ2]"
level=info msg="Desired change: DELETE cname-testdeploy.internal.sandbox.yourdomain.com TXT [Id: /hostedzone/HZ2]"
level=info msg="Desired change: DELETE testdeploy.internal.sandbox.yourdomain.com A [Id: /hostedzone/HZ2]"
level=info msg="Desired change: DELETE testdeploy.internal.sandbox.yourdomain.com A [Id: /hostedzone/HZ2]"
level=info msg="Desired change: DELETE testdeploy.internal.sandbox.yourdomain.com TXT [Id: /hostedzone/HZ2]"
level=info msg="Desired change: DELETE testdeploy.internal.sandbox.yourdomain.com TXT [Id: /hostedzone/HZ2]"
level=error msg="Failure in zone internal.sandbox.yourdomain.com. [Id: /hostedzone/HZ2] when submitting change batch: InvalidChangeBatch: [The request contains an invalid set of changes for a resource record set 'TXT cname-testdeploy.internal.sandbox.yourdomain.com.', The request contains an invalid set of changes for a resource record set 'A testdeploy.internal.sandbox.yourdomain.com.', The request contains an invalid set of changes for a resource record set 'TXT testdeploy.internal.sandbox.yourdomain.com.']\n\tstatus code: 400, request id: X"
level=info msg="Desired change: DELETE cname-testdeploy.internal.sandbox.yourdomain.com TXT [Id: /hostedzone/HZ1]"
level=info msg="Desired change: DELETE cname-testdeploy.internal.sandbox.yourdomain.com TXT [Id: /hostedzone/HZ1]"
level=info msg="Desired change: DELETE testdeploy.internal.sandbox.yourdomain.com A [Id: /hostedzone/HZ1]"
level=info msg="Desired change: DELETE testdeploy.internal.sandbox.yourdomain.com A [Id: /hostedzone/HZ1]"
level=info msg="Desired change: DELETE testdeploy.internal.sandbox.yourdomain.com TXT [Id: /hostedzone/HZ1]"
level=info msg="Desired change: DELETE testdeploy.internal.sandbox.yourdomain.com TXT [Id: /hostedzone/HZ1]"
level=error msg="Failure in zone sandbox.yourdomain.com. [Id: /hostedzone/HZ1] when submitting change batch: InvalidChangeBatch: [The request contains an invalid set of changes for a resource record set 'TXT cname-testdeploy.internal.sandbox.yourdomain.com.', The request contains an invalid set of changes for a resource record set 'A testdeploy.internal.sandbox.yourdomain.com.', The request contains an invalid set of changes for a resource record set 'TXT testdeploy.internal.sandbox.yourdomain.com.']\n\tstatus code: 400, request id: X"
level=error msg="Failed to do run once: soft error\nfailed to submit all changes for the following zones: [/hostedzone/HZ2 /hostedzone/HZ1]"

With the fix:

level=debug msg="Considering zone: /hostedzone/HZ2 (domain: internal.sandbox.yourdomain.com.)"
level=debug msg="Considering zone: /hostedzone/HZ1 (domain: sandbox.yourdomain.com.)"
level=info msg="Desired change: DELETE cname-testdeploy.internal.sandbox.yourdomain.com TXT [Id: /hostedzone/HZ1]"
level=info msg="Desired change: DELETE testdeploy.internal.sandbox.yourdomain.com A [Id: /hostedzone/HZ1]"
level=info msg="Desired change: DELETE testdeploy.internal.sandbox.yourdomain.com TXT [Id: /hostedzone/HZ1]"
level=info msg="3 record(s) in zone sandbox.yourdomain.com. [Id: /hostedzone/HZ1] were successfully updated"
level=info msg="Desired change: DELETE cname-testdeploy.internal.sandbox.yourdomain.com TXT [Id: /hostedzone/HZ2]"
level=info msg="Desired change: DELETE testdeploy.internal.sandbox.yourdomain.com A [Id: /hostedzone/HZ2]"
level=info msg="Desired change: DELETE testdeploy.internal.sandbox.yourdomain.com TXT [Id: /hostedzone/HZ2]"
level=info msg="3 record(s) in zone internal.sandbox.yourdomain.com. [Id: /hostedzone/HZ2] were successfully updated"

Fixes #4241

Checklist

Unit tests updated
End user documentation updated

linux-foundation-easycla · 2024-03-03T08:12:32Z

The committers listed above are authorized under a signed CLA.

✅ login: leonardocaylent (cea0496, 7c7a1c3, e55200a, b8053fe, 846f4b4, deba1ea, 2b3da1b, 82046cc, 3395eba, 9307374, 17ce6b4, 6066b70, 0308cc2, 30c9e77, a3826d5, ba56b7a, d9b7439, 294b4c6, 5190777, 64d0833, f4f39d8, 7fe2d3f, 0ca2796, 56024fd, d3c2f47, 05ca35e, 4fb2f2e, 3ca4d02)

k8s-ci-robot · 2024-03-03T08:12:37Z

Welcome @leonardocaylent!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-03-03T08:12:38Z

Hi @leonardocaylent. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mloiseleur · 2024-03-04T07:51:50Z

/ok-to-test

mloiseleur · 2024-03-04T07:52:40Z

/retitle fix: duplicated endpoint per hosted zone

mloiseleur · 2024-03-04T07:54:19Z

@leonardocaylent Do you think you can add a test on this ?

In order to keep issues fixed for good, we accept PR only when there is a test with it.

leonardocaylent · 2024-03-04T12:36:38Z

@leonardocaylent Do you think you can add a test on this ?

In order to keep issues fixed for good, we accept PR only when there is a test with it.

@mloiseleur Yes, I can. I also need to check for TestAWSRecords and TestAWSApplyChanges that are failing.

yurrriq

We can optimize this a bit by using the empty struct.

yurrriq · 2024-03-04T16:59:54Z

provider/aws/aws.go

+			log.Debugf("Key Output: %s", key)
+			// Initialize the map for the current zone if it doesn't exist
+            if visitedHostnames[aws.StringValue(z.Id)] == nil {
+                visitedHostnames[aws.StringValue(z.Id)] = make(map[string]bool)


Suggested change

visitedHostnames[aws.StringValue(z.Id)] = make(map[string]bool)

visitedHostnames[aws.StringValue(z.Id)] = map[string]struct{}{}

yurrriq · 2024-03-04T17:00:24Z

provider/aws/aws.go

+                visitedHostnames[aws.StringValue(z.Id)] = make(map[string]bool)
+            }
+
+			if visitedHostnames[aws.StringValue(z.Id)][key] {


Suggested change

if visitedHostnames[aws.StringValue(z.Id)][key] {

if _, ok := visitedHostnames[aws.StringValue(z.Id)][key]; ok {

yurrriq · 2024-03-04T17:00:44Z

provider/aws/aws.go

@@ -1008,7 +1021,8 @@ func changesByZone(zones map[string]*route53.HostedZone, changeSet Route53Change
 				}
 			}
 			changes[aws.StringValue(z.Id)] = append(changes[aws.StringValue(z.Id)], c)
-			log.Debugf("Adding %s to zone %s [Id: %s]", hostname, aws.StringValue(z.Name), aws.StringValue(z.Id))
+			visitedHostnames[aws.StringValue(z.Id)][key] = true


Suggested change

visitedHostnames[aws.StringValue(z.Id)][key] = true

visitedHostnames[aws.StringValue(z.Id)][key] = struct{}{}

k8s-ci-robot · 2024-03-04T17:01:58Z

@yurrriq: changing LGTM is restricted to collaborators

In response to this:

We can optimize this a bit by using the empty struct.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…nts-per-hosted-zone-for-aws

leonardocaylent · 2024-04-06T06:34:30Z

@yurrriq The root cause of the issue is that this function lost the ability to remove the duplicate endpoints on the current records at 0.14.0
I tried adding the RemoveDuplicates function in here but does break some unit tests:

--- FAIL: TestPlan (0.11s)
    --- FAIL: TestPlan/TestSyncSecondRound (0.00s)
        plan_test.go:951: expected ["foo 0 IN CNAME  v2 []"] to match []
    --- FAIL: TestPlan/TestSyncSecondRoundMigration (0.00s)
        plan_test.go:951: expected [] to match ["foo 0 IN CNAME  v1 []"]

szuecs · 2024-04-09T11:48:43Z

Please follow up with #4296 (comment). Raffo said what he wants to see and if you want to get this done, then please follow his guideline.
We are happy to review the mentioned PR that you can link back to this one to make sure there is more priority from our side.

leonardocaylent · 2024-04-12T03:02:14Z

@szuecs I've read @Raffo's comments. We were working with @yurrriq and @cronik and we found the root cause. I'll put here a brief summary:
1)About the unit tests, they are a little missleading (having a same DNS name for an A record and a CNAME at the same time) but for the test purposes @cronik said the intention was to test the behavior, not the validation of being able to create both records. This issue was created because is related to this but we think it's not a priority or needs to be addresed on the #4241
2)We found that duplicated endpoints were always at the records variable on controller.go, the real root cause of the issue was that on this Pull Request multi-cluster-fix the plans started to be different:

		Behavior on 0.14.0 on Deletes
		------------------------------------------------------------------------------------------------------
		DNSName          | Current record                                      | Desired Records (Candidate) |
		------------------------------------------------------------------------------------------------------
		dnsname.zone.com |[dnsname.zone.com IN A]dnsname.zone.com IN A (dup ep)| []                          |
		------------------------------------------------------------------------------------------------------
	
		Behavior on 0.13.6 on Deletes
		------------------------------------------------------------------------------------------------------
		DNSName          | Current record                                      | Desired Records (Candidate) |
		------------------------------------------------------------------------------------------------------
		dnsname.zone.com | [dnsname.zone.com IN CNAME ]                        | []                          |
		------------------------------------------------------------------------------------------------------

3)I didn't see any new comments between @Raffo's comment and the new finding so I think that changes the solution. The things are on the current PR but the last commit (d9b7439) it's a Draft and it's really complex to explain on a comment. I'm still working on the solution because we find the real root cause only 5 days ago, which was merged into main 7 months ago. I'd really appreciate if some of the contributors with more experience have time to discuss in a huddle about this.
If that's not possible I'll post on the original-issue to ask another review to this pull request, if that's not the way to contribute or I'm failing with some of the steps please reach out to me and I'll stop doing that. I'm new here and I just want contribute my grain of sand to k8s.

…nts-per-hosted-zone-for-aws

leonardocaylent · 2024-04-23T03:06:01Z

@Raffo We could confirm that
1)The behavior on the new version is different:
Behavior on 0.13.6 on Deletes:

DNS Name : dnsname.zone.com
Current record: 
dnsname.zone.com 300 IN CNAME  k8s-ingre-1234abcd.us-west-2.elb.amazonaws.com [{aws/evaluate-target-health true} {alias true}] 
Desired Records (Candidate): []

Behavior on 0.14.0 on Deletes:

DNS Name : dnsname.zone.com
Current record: 
dnsname.zone.com 300 IN A  k8s-ingre-1234abcd.us-west-2.elb.amazonaws.com [{aws/evaluate-target-health true} {alias true}] 
dnsname.zone.com 300 IN A  k8s-ingre-1234abcd.us-west-2.elb.amazonaws.com [{aws/evaluate-target-health true} {alias true}] 
Desired Records (Candidate): []

2)There were 2 major changes on plan.go, the Record Type included in the plan, and the ability to remove duplicated endpoints on changes.Delete
3)The variable records on controller.go is working fine, it contains duplicated endpoints at that time because it's reflecting the current state of the DNS records on the provider, to have a low impact the change needs to be applied only on plan.go
4)This could be considered a fix to have the previous behavior prior to #3747 , but after having this in place, we could work on a feature for AWS "Creating the dns records for endpoints only in the Hosted Zone that has the best fit". A good starting point would be on the suitableZones function, but I guess we should have some discussion about if having the records in only one hosted zone needs some type of regression. The ideal change would be if this new feature makes changes.Delete to detect the unnecessary records in the duplicated/triplicated hosted zones.

From my point of view, this PR is ready to review. Special thanks to all the persons that helped finding the root cause of this issue.

…nts-per-hosted-zone-for-aws

yurrriq

lgtm, I agree that any changes to the AWS provider to choose the most suitable zone are best addressed in a followup issue and PR

k8s-ci-robot · 2024-04-24T15:26:55Z

@yurrriq: changing LGTM is restricted to collaborators

In response to this:

lgtm, I agree that any changes to the AWS provider to choose the most suitable zone are best addressed in a followup issue and PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Raffo · 2024-05-03T20:59:37Z

@leonardocaylent thank you for the update and the work with the rest of the community to figure out what the best path forward is. I followed the last updates and the change proposed seems reasonable to me. @szuecs @mloiseleur is the change fine for you as well? I feel that you followed this more closely, so I want to wait for your okay for this to proceed.

mloiseleur · 2024-05-04T07:22:38Z

This change is working and lgtm. Even if it's an edge case, I understand it was working before.
I (really) hope that we will be able to fix the source and remove this code.

Raffo · 2024-05-06T05:45:52Z

I (really) hope that we will be able to fix the source and remove this code.

@mloiseleur yes, same. Do we want to get this in and work on the more permanent fix then? Does this require a release? Who's working on the second part? Sorry tons of questions 😅

leonardocaylent · 2024-05-06T13:18:45Z

I (really) hope that we will be able to fix the source and remove this code.

@mloiseleur yes, same. Do we want to get this in and work on the more permanent fix then? Does this require a release? Who's working on the second part? Sorry tons of questions 😅

@Raffo I can work on the second part with help of someone does has experience and knowledge on the aws provider. The final fix will require the same amount of testing and debugging than this one (quite a lot)

leonardocaylent · 2024-05-08T21:33:58Z

@Raffo @mloiseleur I agree that we want to get this merged in since the functionality of the plans changed and this will require a release. I also agree that we will be able to fix the source and remove this code entirely when we only generate one of each record in the correct hosted zone.

Raffo · 2024-05-09T07:42:19Z

Ok so the plan is:

I take a final review at this.
If all is good, I merge.
I kick off the release process for v0.14.2.
We start working on the better fix and proceed accordingly.

Does this sound correct?

leonardocaylent · 2024-05-09T16:55:34Z

Ok so the plan is:

I take a final review at this.

If all is good, I merge.

I kick off the release process for v0.14.2.

We start working on the better fix and proceed accordingly.

Does this sound correct?

That sounds perfect, I created this feature ticket to start the discussion about how to proceed with that. I explained with details the current behavior.

Raffo · 2024-05-10T07:36:12Z

/lgtm
/approve

k8s-ci-robot · 2024-05-10T07:36:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo, yurrriq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Raffo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…rnal-dns to v0.14.2@3fcad62 by renovate (#22163) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [registry.k8s.io/external-dns/external-dns](https://github.com/kubernetes-sigs/external-dns) | patch | `v0.14.1` -> `v0.14.2` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes-sigs/external-dns (registry.k8s.io/external-dns/external-dns)</summary> ### [`v0.14.2`](https://github.com/kubernetes-sigs/external-dns/releases/tag/v0.14.2) [Compare Source](https://github.com/kubernetes-sigs/external-dns/compare/v0.14.1...v0.14.2) #### What's Changed - kustomize-v0.14.1 by [@Raffo](https://github.com/Raffo) in [kubernetes-sigs/external-dns#4331 - replace all links in tutorials for v0.14.1 by [@Raffo](https://github.com/Raffo) in [kubernetes-sigs/external-dns#4332 - chore: upgrade ExternalDNS to go 1.22 by [@mloiseleur](https://github.com/mloiseleur) in [kubernetes-sigs/external-dns#4318 - build(deps): bump the dev-dependencies group with 13 updates by [@dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4329 - build(deps): bump the dev-dependencies group with 5 updates by [@dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4334 - build(deps): bump the dev-dependencies group with 9 updates by [@dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4349 - build(deps): bump the dev-dependencies group with 1 update by [@dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4341 - Add `dnsendpoint` CRD to Helm chart by [@onedr0p](https://github.com/onedr0p) in [kubernetes-sigs/external-dns#4322 - build(deps): bump the dev-dependencies group with 13 updates by [@dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4361 - build(deps): bump GrantBirki/json-yaml-validate from 2.6.1 to 2.6.2 in the dev-dependencies group by [@dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4364 - chore(chart): Released chart for v0.14.1 by [@stevehipwell](https://github.com/stevehipwell) in [kubernetes-sigs/external-dns#4357 - chore: alphabetical order on providers by [@mloiseleur](https://github.com/mloiseleur) in [kubernetes-sigs/external-dns#4350 - doc: advertise current plan on providers by [@mloiseleur](https://github.com/mloiseleur) in [kubernetes-sigs/external-dns#4365 - Fix(ipv6): support ipv6 shortener and expander equal by [@dongjiang1989](https://github.com/dongjiang1989) in [kubernetes-sigs/external-dns#4351 - feat(WebhookProvider): Let WebhookProvider return `SoftError` on response status codes >= 500 by [@SimonKienzler](https://github.com/SimonKienzler) in [kubernetes-sigs/external-dns#4319 - Webhook provider: Use correct error gauge in `AdjustEndpoints()` func by [@SimonKienzler](https://github.com/SimonKienzler) in [kubernetes-sigs/external-dns#4374 - build(deps): bump the dev-dependencies group with 18 updates by [@dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4381 - Add exclude domains value in Chart by [@bford-evs](https://github.com/bford-evs) in [kubernetes-sigs/external-dns#4380 - docs(aws): fix typo and upgrade cleanup flow by [@franzudev](https://github.com/franzudev) in [kubernetes-sigs/external-dns#4389 - docs(gke): detail how to configure workload identity by [@userbradley](https://github.com/userbradley) in [kubernetes-sigs/external-dns#4373 - chore(ci): fix failing test by [@mloiseleur](https://github.com/mloiseleur) in [kubernetes-sigs/external-dns#4397 - chore: Update controller-tools version to v0.14.0 by [@dongjiang1989](https://github.com/dongjiang1989) in [kubernetes-sigs/external-dns#4400 - chore(ci): update golangci-lint to v1.57.2 by [@dongjiang1989](https://github.com/dongjiang1989) in [kubernetes-sigs/external-dns#4406 - chore: upgrade ExternalDNS to go 1.22.2 by [@mloiseleur](https://github.com/mloiseleur) in [kubernetes-sigs/external-dns#4414 - build(deps): bump the dev-dependencies group across 1 directory with 4 updates by [@dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4412 - build(deps): bump the dev-dependencies group across 1 directory with 24 updates by [@dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4416 - custom Azure Active Directory Authority Host by [@Jeremy-Boyle](https://github.com/Jeremy-Boyle) in [kubernetes-sigs/external-dns#4210 - feat(DNSimple): User API tokens by [@IntegralProgrammer](https://github.com/IntegralProgrammer) in [kubernetes-sigs/external-dns#4274 - docs: annotation placement for azuredns tutorial by [@jonas-budde](https://github.com/jonas-budde) in [kubernetes-sigs/external-dns#4415 - feat(azure): add zone name filter for Azure Private DNS by [@khuedoan](https://github.com/khuedoan) in [kubernetes-sigs/external-dns#4346 - test: detect no change necessary with provider specific config by [@szuecs](https://github.com/szuecs) in [kubernetes-sigs/external-dns#4189 - docs: add setup example with helm chart on some providers by [@omerap12](https://github.com/omerap12) in [kubernetes-sigs/external-dns#4405 - test: controller run() and successfully shutdown by [@szuecs](https://github.com/szuecs) in [kubernetes-sigs/external-dns#3639 - fix syntax on cloudflare externalDNS by [@ilyesAj](https://github.com/ilyesAj) in [kubernetes-sigs/external-dns#4436 - build(deps): bump the dev-dependencies group across 1 directory with 11 updates by [@dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4440 - chore(chart): Adding extra containers by [@omerap12](https://github.com/omerap12) in [kubernetes-sigs/external-dns#4432 - aws: add ca-west-1 region by [@jeremy-albuixech](https://github.com/jeremy-albuixech) in [kubernetes-sigs/external-dns#4444 - fix: duplicated endpoint per hosted zone by [@leonardocaylent](https://github.com/leonardocaylent) in [kubernetes-sigs/external-dns#4296 - build(deps): bump actions/checkout from 4.1.4 to 4.1.5 in the dev-dependencies group by [@dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4438 - Add IPv6 AAAA record support to PiHole provider by [@PseudoResonance](https://github.com/PseudoResonance) in [kubernetes-sigs/external-dns#4324 - fix: soft error on cloudflare rate limits by [@ebachle](https://github.com/ebachle) in [kubernetes-sigs/external-dns#4437 - Update cloudflare.md by [@mfreeman451](https://github.com/mfreeman451) in [kubernetes-sigs/external-dns#4449 - Fix headings, whitespace by [@stefanlasiewski](https://github.com/stefanlasiewski) in [kubernetes-sigs/external-dns#4457 - docs: add reference to anexia webhook provider by [@ProbstenHias](https://github.com/ProbstenHias) in [kubernetes-sigs/external-dns#4441 - fix logline mentioning plugin api by [@Raffo](https://github.com/Raffo) in [kubernetes-sigs/external-dns#4459 - docs: lint gke docs + make terraform config more secure by [@DrFaust92](https://github.com/DrFaust92) in [kubernetes-sigs/external-dns#4456 - build(deps): bump action-stars/install-tool-from-github-release from 0.2.2 to 0.2.3 in the dev-dependencies group by [@dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4464 - changed documentation to include more details description when using API Tokens by [@rhjensen79](https://github.com/rhjensen79) in [kubernetes-sigs/external-dns#4474 - fix: add clarification to endpoint unit tests by [@leonardocaylent](https://github.com/leonardocaylent) in [kubernetes-sigs/external-dns#4462 - build(deps): bump the dev-dependencies group across 1 directory with 19 updates by [@mloiseleur](https://github.com/mloiseleur) in [kubernetes-sigs/external-dns#4476 - build(deps): bump the dev-dependencies group across 1 directory with 19 updates by [@dependabot](https://github.com/dependabot) in [kubernetes-sigs/external-dns#4475 #### New Contributors - [@onedr0p](https://github.com/onedr0p) made their first contribution in [kubernetes-sigs/external-dns#4322 - [@SimonKienzler](https://github.com/SimonKienzler) made their first contribution in [kubernetes-sigs/external-dns#4319 - [@bford-evs](https://github.com/bford-evs) made their first contribution in [kubernetes-sigs/external-dns#4380 - [@franzudev](https://github.com/franzudev) made their first contribution in [kubernetes-sigs/external-dns#4389 - [@userbradley](https://github.com/userbradley) made their first contribution in [kubernetes-sigs/external-dns#4373 - [@Jeremy-Boyle](https://github.com/Jeremy-Boyle) made their first contribution in [kubernetes-sigs/external-dns#4210 - [@IntegralProgrammer](https://github.com/IntegralProgrammer) made their first contribution in [kubernetes-sigs/external-dns#4274 - [@jonas-budde](https://github.com/jonas-budde) made their first contribution in [kubernetes-sigs/external-dns#4415 - [@khuedoan](https://github.com/khuedoan) made their first contribution in [kubernetes-sigs/external-dns#4346 - [@omerap12](https://github.com/omerap12) made their first contribution in [kubernetes-sigs/external-dns#4405 - [@ilyesAj](https://github.com/ilyesAj) made their first contribution in [kubernetes-sigs/external-dns#4436 - [@jeremy-albuixech](https://github.com/jeremy-albuixech) made their first contribution in [kubernetes-sigs/external-dns#4444 - [@leonardocaylent](https://github.com/leonardocaylent) made their first contribution in [kubernetes-sigs/external-dns#4296 - [@PseudoResonance](https://github.com/PseudoResonance) made their first contribution in [kubernetes-sigs/external-dns#4324 - [@ebachle](https://github.com/ebachle) made their first contribution in [kubernetes-sigs/external-dns#4437 - [@mfreeman451](https://github.com/mfreeman451) made their first contribution in [kubernetes-sigs/external-dns#4449 - [@ProbstenHias](https://github.com/ProbstenHias) made their first contribution in [kubernetes-sigs/external-dns#4441 - [@DrFaust92](https://github.com/DrFaust92) made their first contribution in [kubernetes-sigs/external-dns#4456 - [@rhjensen79](https://github.com/rhjensen79) made their first contribution in [kubernetes-sigs/external-dns#4474 **Full Changelog**: kubernetes-sigs/external-dns@v0.14.1...v0.14.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

leonardocaylent added 2 commits March 3, 2024 04:46

Group By Endpoint names per Hosted Zone on AWS

b8053fe

Group By Endpoint names per Hosted Zone on AWS

e55200a

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2024

k8s-ci-robot requested review from johngmyers and szuecs March 3, 2024 08:12

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 3, 2024

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 3, 2024

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 3, 2024

leonardocaylent added 2 commits March 3, 2024 16:36

Group By Endpoint names per Hosted Zone on AWS

7c7a1c3

Group By Endpoint names per Hosted Zone on AWS

9307374

leonardocaylent changed the title ~~Group By Endpoint names per Hosted Zone on AWS~~ Group By EndpointName_RecordType per Hosted Zone on AWS Mar 3, 2024

leonardocaylent marked this pull request as ready for review March 3, 2024 20:39

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2024

leonardocaylent mentioned this pull request Mar 3, 2024

v.0.14.0 [AWS] External-DNS cannot remove records from 2 Route 53 hosted zones (InvalidChangeBatch: [The request contains an invalid set of changes]) #4241

Closed

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 4, 2024

k8s-ci-robot changed the title ~~Group By EndpointName_RecordType per Hosted Zone on AWS~~ fix: duplicated endpoint per hosted zone Mar 4, 2024

yurrriq suggested changes Mar 4, 2024

View reviewed changes

Going back to endpoint.go

846f4b4

k8s-ci-robot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 5, 2024

leonardocaylent added 2 commits April 6, 2024 03:05

Merge remote-tracking branch 'origin/master' into bugfix/group-endpoi…

ba56b7a

…nts-per-hosted-zone-for-aws

Specify and clarify root cause of issue 4241

d9b7439

leonardocaylent requested a review from yurrriq April 6, 2024 06:28

mloiseleur mentioned this pull request Apr 8, 2024

Created a wildcard record even there is no * host record in ingress rules #4348

Open

leonardocaylent added 3 commits April 22, 2024 20:36

Merge remote-tracking branch 'origin/master' into bugfix/group-endpoi…

05ca35e

…nts-per-hosted-zone-for-aws

Final fix for error on delete

64d0833

Fix unrelated change on service_test.go address

5190777

Merge remote-tracking branch 'origin/master' into bugfix/group-endpoi…

56024fd

…nts-per-hosted-zone-for-aws

yurrriq approved these changes Apr 24, 2024

View reviewed changes

leonardocaylent mentioned this pull request May 9, 2024

[AWS][Feature/Enhancement] Make suitableZones select only one Hosted Zone to create the Route53 records (even if it's public or private) #4454

Open

k8s-ci-robot assigned Raffo May 10, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2024

k8s-ci-robot merged commit 03a2c66 into kubernetes-sigs:master May 10, 2024
13 checks passed

leonardocaylent mentioned this pull request May 11, 2024

fix: add clarification to endpoint unit tests #4462

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: duplicated endpoint per hosted zone #4296

fix: duplicated endpoint per hosted zone #4296

leonardocaylent commented Mar 3, 2024 •

edited

Loading

linux-foundation-easycla bot commented Mar 3, 2024 •

edited

Loading

k8s-ci-robot commented Mar 3, 2024

k8s-ci-robot commented Mar 3, 2024

mloiseleur commented Mar 4, 2024

mloiseleur commented Mar 4, 2024

mloiseleur commented Mar 4, 2024

leonardocaylent commented Mar 4, 2024 •

edited

Loading

yurrriq left a comment

yurrriq Mar 4, 2024

yurrriq Mar 4, 2024

yurrriq Mar 4, 2024

k8s-ci-robot commented Mar 4, 2024

leonardocaylent commented Apr 6, 2024

szuecs commented Apr 9, 2024

leonardocaylent commented Apr 12, 2024

leonardocaylent commented Apr 23, 2024

yurrriq left a comment

k8s-ci-robot commented Apr 24, 2024

Raffo commented May 3, 2024

mloiseleur commented May 4, 2024

Raffo commented May 6, 2024

leonardocaylent commented May 6, 2024

leonardocaylent commented May 8, 2024

Raffo commented May 9, 2024

leonardocaylent commented May 9, 2024

Raffo commented May 10, 2024

k8s-ci-robot commented May 10, 2024

	visitedHostnames[aws.StringValue(z.Id)] = make(map[string]bool)
	visitedHostnames[aws.StringValue(z.Id)] = map[string]struct{}{}

	if visitedHostnames[aws.StringValue(z.Id)][key] {
	if _, ok := visitedHostnames[aws.StringValue(z.Id)][key]; ok {

	visitedHostnames[aws.StringValue(z.Id)][key] = true
	visitedHostnames[aws.StringValue(z.Id)][key] = struct{}{}

fix: duplicated endpoint per hosted zone #4296

fix: duplicated endpoint per hosted zone #4296

Conversation

leonardocaylent commented Mar 3, 2024 • edited Loading

linux-foundation-easycla bot commented Mar 3, 2024 • edited Loading

k8s-ci-robot commented Mar 3, 2024

k8s-ci-robot commented Mar 3, 2024

mloiseleur commented Mar 4, 2024

mloiseleur commented Mar 4, 2024

mloiseleur commented Mar 4, 2024

leonardocaylent commented Mar 4, 2024 • edited Loading

yurrriq left a comment

Choose a reason for hiding this comment

yurrriq Mar 4, 2024

Choose a reason for hiding this comment

yurrriq Mar 4, 2024

Choose a reason for hiding this comment

yurrriq Mar 4, 2024

Choose a reason for hiding this comment

k8s-ci-robot commented Mar 4, 2024

leonardocaylent commented Apr 6, 2024

szuecs commented Apr 9, 2024

leonardocaylent commented Apr 12, 2024

leonardocaylent commented Apr 23, 2024

yurrriq left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Apr 24, 2024

Raffo commented May 3, 2024

mloiseleur commented May 4, 2024

Raffo commented May 6, 2024

leonardocaylent commented May 6, 2024

leonardocaylent commented May 8, 2024

Raffo commented May 9, 2024

leonardocaylent commented May 9, 2024

Raffo commented May 10, 2024

k8s-ci-robot commented May 10, 2024

leonardocaylent commented Mar 3, 2024 •

edited

Loading

linux-foundation-easycla bot commented Mar 3, 2024 •

edited

Loading

leonardocaylent commented Mar 4, 2024 •

edited

Loading