Add IPv6 AAAA record support to PiHole provider

[PseudoResonance]

Description

Adds support for modifying IPv6 AAAA records with the PiHole provider. PiHole makes no distinction between A and AAAA records in their API, the main distinction being if the record contains periods or colons.

To address this, I simply allowed external-dns to push AAAA records as needed, and filtered out the incorrect record types when retrieving the current list.

Checklist

• Unit tests updated
• End user documentation updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: PseudoResonance / name: Josh (a48287b, f8a9c07, 7b43890, 332f679, b4d76a9)

[k8s-ci-robot]

Welcome @PseudoResonance!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @PseudoResonance. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[PseudoResonance]

I apologize for the force push, I made a typo in my email. I was also unable to find any relevant documentation or tests that are affected by this change, but I can take a look if there's something that needs to be adjusted of course.

[szuecs]

@PseudoResonance no feature without test and docs

[PseudoResonance]

Sorry for the delay, I completely forgot to check back on this. It should be good now, I duplicated all the A record tests to make sure they work for AAAA records.

[szuecs]

/ok-to-test
/lgtm

[szuecs]

@PseudoResonance

- FAIL: TestServiceSource (0.11s)
    --- FAIL: TestServiceSource/Endpoints (0.00s)
        --- FAIL: TestServiceSource/Endpoints/annotated_services_return_an_endpoint_with_hostname_then_resolve_hostname (0.20s)
            service_test.go:1141: Targets expected "93.184.216.34", got "93.184.215.14"
            service_test.go:1141: Targets expected "2606:2800:220:1:248:1893:25c8:1946", got "2606:2800:21f:cb07:6820:80da:af6b:8b2c"
FAIL

[szuecs]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [szuecs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment