Validate license boilerplate in CI builds #183
Conversation
In order for the Dockerfile to be picked up by the validator, it needs to be renamed Dockerfile.build->Dockerfile
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
=======================================
Coverage 50.91% 50.91%
=======================================
Files 13 13
Lines 711 711
=======================================
Hits 362 362
Misses 297 297
Partials 52 52
Continue to review full report at Codecov.
|
| @@ -16,7 +16,7 @@ | |||
| # as well as "latest" | |||
| steps: | |||
| - name: 'gcr.io/cloud-builders/docker' | |||
| args: ['build', '-t', 'builder', '-f', 'hack/Dockerfile.build', '.'] | |||
| args: ['build', '-t', 'builder', '-f', 'hack/Dockerfile', '.'] | |||
There was a problem hiding this comment.
this seems like an unrelated change?
There was a problem hiding this comment.
I explained in the commit message: if the Dockerfile has this non-standard name, it is not picked up by the license boilerplate validation.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
/lgtm Thanks! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, corneliusweig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Adding corneliusweig to owners. He has been consistently helping both with krew and krew-index repositories in terms of: - developing plugins himself - taking a stab at krew machinery with large scale code refactors - adding integration test suite to the project - adding more validation and test cases - increasing developer documentation Some of his notable work: - kubernetes-sigs#195 - kubernetes-sigs#183 - kubernetes-sigs#191 - kubernetes-sigs#201 - kubernetes-sigs#202 - kubernetes-sigs#203 - kubernetes-sigs#208 He is familiar with the codebase enough to officially review and approve code. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Adding corneliusweig to owners. He has been consistently helping both with krew and krew-index repositories in terms of: - developing plugins himself - taking a stab at krew machinery with large scale code refactors - adding integration test suite to the project - adding more validation and test cases - increasing developer documentation Some of his notable work: - #195 - #183 - #191 - #201 - #202 - #203 - #208 He is familiar with the codebase enough to officially review and approve code. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Also fix the copyright notice where necessary.
Fix #173