Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make corneliusweig a maintainer #214

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Conversation

ahmetb
Copy link
Member

@ahmetb ahmetb commented Jun 14, 2019

Adding corneliusweig to owners. He has been consistently helping both with
krew and krew-index repositories in terms of:

  • developing plugins himself
  • taking a stab at krew machinery with large scale code refactors
  • adding integration test suite to the project
  • adding more validation and test cases
  • increasing developer documentation

Some of his notable work:

He is familiar with the codebase enough to officially review and approve code.

Adding corneliusweig to owners. He has been consistently helping both with
krew and krew-index repositories in terms of:
- developing plugins himself
- taking a stab at krew machinery with large scale code refactors
- adding integration test suite to the project
- adding more validation and test cases
- increasing developer documentation

Some of his notable work:
- kubernetes-sigs#195
- kubernetes-sigs#183
- kubernetes-sigs#191
- kubernetes-sigs#201
- kubernetes-sigs#202
- kubernetes-sigs#203
- kubernetes-sigs#208

He is familiar with the codebase enough to officially review and approve code.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2019
@codecov-io
Copy link

Codecov Report

Merging #214 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #214   +/-   ##
=======================================
  Coverage   53.77%   53.77%           
=======================================
  Files          13       13           
  Lines         716      716           
=======================================
  Hits          385      385           
  Misses        279      279           
  Partials       52       52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95a9ad7...18ea1a6. Read the comment docs.

@corneliusweig
Copy link
Contributor

Thanks @ahmetb for your trust in me. I hope to be a good steward for krew!

@ahmetb ahmetb merged commit aecfd53 into kubernetes-sigs:master Jun 18, 2019
@ahmetb
Copy link
Member Author

ahmetb commented Jun 18, 2019

I went ahead and merged this as Juan seems to be away and Maciej isnt in OWNERS.

corneliusweig added a commit to corneliusweig/krew-index that referenced this pull request Jun 21, 2019
k8s-ci-robot pushed a commit to kubernetes-sigs/krew-index that referenced this pull request Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants