-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make corneliusweig a maintainer #214
Conversation
Adding corneliusweig to owners. He has been consistently helping both with krew and krew-index repositories in terms of: - developing plugins himself - taking a stab at krew machinery with large scale code refactors - adding integration test suite to the project - adding more validation and test cases - increasing developer documentation Some of his notable work: - kubernetes-sigs#195 - kubernetes-sigs#183 - kubernetes-sigs#191 - kubernetes-sigs#201 - kubernetes-sigs#202 - kubernetes-sigs#203 - kubernetes-sigs#208 He is familiar with the codebase enough to officially review and approve code. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #214 +/- ##
=======================================
Coverage 53.77% 53.77%
=======================================
Files 13 13
Lines 716 716
=======================================
Hits 385 385
Misses 279 279
Partials 52 52 Continue to review full report at Codecov.
|
Thanks @ahmetb for your trust in me. I hope to be a good steward for |
I went ahead and merged this as Juan seems to be away and Maciej isnt in OWNERS. |
Adding corneliusweig to owners. He has been consistently helping both with
krew and krew-index repositories in terms of:
Some of his notable work:
He is familiar with the codebase enough to officially review and approve code.