Add contributor documentation and helper scripts #201
Conversation
Add instruction for docker sandbox
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
=======================================
Coverage 53.77% 53.77%
=======================================
Files 13 13
Lines 716 716
=======================================
Hits 385 385
Misses 279 279
Partials 52 52Continue to review full report at Codecov.
|
check-code-patterns.sh -> verify-code-patterns.sh run_lint.sh -> run-lint.sh This ensures a more consistent naming pattern
|
|
|
|
||
| WORKDIR /go/src/sigs.k8s.io/krew | ||
|
|
||
| # build binary |
There was a problem hiding this comment.
I think we really shouldn't repeat the build process here. I highly recommend we just refactor the script that starts the container to do something like:
OSARCH=linux/amd64 hack/make-binaries.sh
docker run --rm -i -t -v ./out/bin/krew-linux_amd64:/bin/krew
There was a problem hiding this comment.
Hmm.. that will need a lot of extra work. I think I will remove the docker sandbox instead and submit that as a separate PR when gox is gone.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, corneliusweig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Adding corneliusweig to owners. He has been consistently helping both with krew and krew-index repositories in terms of: - developing plugins himself - taking a stab at krew machinery with large scale code refactors - adding integration test suite to the project - adding more validation and test cases - increasing developer documentation Some of his notable work: - kubernetes-sigs#195 - kubernetes-sigs#183 - kubernetes-sigs#191 - kubernetes-sigs#201 - kubernetes-sigs#202 - kubernetes-sigs#203 - kubernetes-sigs#208 He is familiar with the codebase enough to officially review and approve code. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Adding corneliusweig to owners. He has been consistently helping both with krew and krew-index repositories in terms of: - developing plugins himself - taking a stab at krew machinery with large scale code refactors - adding integration test suite to the project - adding more validation and test cases - increasing developer documentation Some of his notable work: - #195 - #183 - #191 - #201 - #202 - #203 - #208 He is familiar with the codebase enough to officially review and approve code. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
This still has no information for:
For one, I think I'm not in the position to make guidelines here. In addition, I think a process needs to be established to add appropriate labels.
See #200