Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove role for configmaps/status which do not exists from leader_election_role.yaml #1511

Merged
merged 1 commit into from
Jun 20, 2020
Merged

fix: remove role for configmaps/status which do not exists from leader_election_role.yaml #1511

merged 1 commit into from
Jun 20, 2020

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented May 9, 2020 •
edited
Loading

Closes: #1473

Theoretically, any deletion would be a breaking change. However, in this case, we are scaffolding something that does not exist and has no value at all. So, because of this was done for V2,V3.

blocked;

TODO: Apply to V3 plugin 2.X only.
Waiting for #1498

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 9, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 9, 2020
@camilamacedo86 camilamacedo86 changed the title fix: remove role for configmaps/status which not exist fix: remove role for configmaps/status which do not exists May 9, 2020
@camilamacedo86
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2020
rahulchheda
rahulchheda approved these changes Jun 3, 2020
View reviewed changes
Copy link

@rahulchheda rahulchheda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@rahulchheda: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@camilamacedo86
Copy link
Member Author

TODO: Apply to V3 plugin 2.X only.
Waiting for #1498

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2020
@camilamacedo86 camilamacedo86 changed the title fix: remove role for configmaps/status which do not exists fix: remove role for configmaps/status which do not exists from leader_election_role.yaml Jun 19, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2020
@camilamacedo86
Copy link
Member Author

/hold cancel
it is applied just for 3-alpha now.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2020
djzager
djzager approved these changes Jun 19, 2020
View reviewed changes
Copy link

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-15-3

@k8s-ci-robot k8s-ci-robot merged commit bc77431 into kubernetes-sigs:master Jun 20, 2020
@camilamacedo86 camilamacedo86 deleted the fix-remove-perm-not-exist branch June 20, 2020 09:31
@camilamacedo86 camilamacedo86 mentioned this pull request Jul 15, 2020
Merged
2 tasks
@camilamacedo86 camilamacedo86 mentioned this pull request Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djzager djzager djzager approved these changes

@rahulchheda rahulchheda rahulchheda approved these changes

@joelanford joelanford Awaiting requested review from joelanford

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@djzager djzager

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

leader-election-role role refers to non-existent configmaps/status resource
4 participants
@camilamacedo86 @k8s-ci-robot @djzager @rahulchheda