Fork github.com/go-openapi/{spec,validate,errors,strfmt} #211

sttts · 2020-10-28T15:13:08Z

4.6k lines of Go
3.2k lines of tests

versus 40k for the whole go-openapi suite.

Background: go-openapi has very different goal than we do. Every change in behaviour of the validation library has potential influence on our API. go-openapi is supposed to improve over time and support more and more OpenAPI features. We need a stable basis that does not change behaviour at all, or only under tight control with API back and forward compatibility in mind.

marshal unmarshal item of parameter with vendorExtensible

Reference Resolution

Fixes kubernetes#33

Add Example field to SimpleSchema

When the input schema is nil, `NewSchemaValidator` will return a nil `*SchemaValidator`. This nil `*SchemaValidator` is passed to `Validate`, which panics when `s.validators` is called.

Fixes go-swagger/go-swagger#1281

Don't drop empty arrays of operations security definitions

This fixes a regression introduced by kubernetes#39. Turns out security: null breaks the validator as it expected either no field at all or an array. OperatioProperties now have a custom marshaller that ensures that: 1. empty slices are preserved as empty arrays in JSON 2. if Security is unset/nil the key is omitted in JSON

Avoid null value when serializing operations

* remove unnecessary debug logs * allow trailing slash * use strings.TrimRight * intermediate commit * a commit that passes the validation tests * remove refmodifier * remove comments for easier review * fixed tests * remove unnecessary debug messages * remove some previously commented code

* fixing paths for windows * remove debugging artifacts

Fixes kubernetes#43 Signed-off-by: Igor Zibarev <zibarev.i@gmail.com>

Consistently check if RelativeBase is empty

Fixes kubernetes#45 Signed-off-by: Igor Zibarev <zibarev.i@gmail.com>

k8s-ci-robot · 2020-11-05T09:54:50Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

gautierdelorme

Just a few comments about the new versions.

gautierdelorme · 2020-11-05T09:47:52Z

go.mod

-	github.com/go-openapi/spec v0.0.0-20160808142527-6aced65f8501
-	github.com/go-openapi/swag v0.0.0-20160704191624-1d0bd113de87 // indirect
+	github.com/go-openapi/jsonpointer v0.19.3
+	github.com/go-openapi/jsonreference v0.19.4


Doesn't k/k uses v0.19.3?

gautierdelorme · 2020-11-05T09:48:39Z

go.mod

-	github.com/go-openapi/swag v0.0.0-20160704191624-1d0bd113de87 // indirect
+	github.com/go-openapi/jsonpointer v0.19.3
+	github.com/go-openapi/jsonreference v0.19.4
+	github.com/go-openapi/spec v0.19.12


Doesn't k/k uses v0.19.3?

gautierdelorme · 2020-11-05T09:48:51Z

go.mod

+	github.com/go-openapi/jsonpointer v0.19.3
+	github.com/go-openapi/jsonreference v0.19.4
+	github.com/go-openapi/spec v0.19.12
+	github.com/go-openapi/swag v0.19.11


Doesn't k/k uses v0.19.5?

gautierdelorme · 2020-11-05T09:51:07Z

go.mod

 	github.com/munnerz/goautoneg v0.0.0-20120707110453-a547fc61f48d
 	github.com/onsi/ginkgo v0.0.0-20170829012221-11459a886d9c
 	github.com/onsi/gomega v0.0.0-20170829124025-dcabb60a477c
 	github.com/spf13/pflag v0.0.0-20170130214245-9ff6c6923cff
 	github.com/stretchr/testify v1.3.0
 	golang.org/x/net v0.0.0-20200324143707-d3edc9973b7e // indirect
 	golang.org/x/tools v0.0.0-20181011042414-1f849cf54d09 // indirect
-	gopkg.in/yaml.v2 v2.2.2
+	gopkg.in/yaml.v2 v2.3.0


I think k/k uses v2.2.8?

gautierdelorme · 2020-11-05T09:55:14Z

go.mod

 	github.com/googleapis/gnostic v0.4.1
 	github.com/json-iterator/go v1.1.6
-	github.com/mailru/easyjson v0.0.0-20160728113105-d5b7844b561a // indirect
+	github.com/kr/text v0.2.0 // indirect


k/k uses v0.1.0 but I don't think it should matter looking at kr/text@v0.1.0...v0.2.0 and creack/pty@v1.1.7...v1.1.9.

We had contributed this upstream, but never used it due to structural schemas.

k8s-ci-robot · 2020-11-05T10:15:17Z

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

e291569 Fix panic when json.Number value is in a string field
ae13823 Consistently check if RelativeBase is empty
6ef9882 Fix expandSchema when basePath is empty
7bcb96a fix Move openapi proto parsing and indexing #10 - add error factor must be positive (initialise schemaTypeFormatMap once at package level #11)
d5d4826 Fixes Create a SECURITY_CONTACTS file. #75
b1a574a - fixes Typo fix in swagger.json: mulitple->multiple #65
af4c70f Hang when expanding circular $ref
b79fccf Hang when expanding circular $ref
e2e66a1 * Circular ref, cont'd: absolutized initial root path passed with options
41df026 Completed test for ServeError with nil Error, as discussed in Seeking advice for generating openapi spec for CRD #13
6232591 Fixes Endpoint properly handles Accept header #36 Hostname matching doesn't conform to modern hostname patterns
b7bbaf9 Merge pull request add support for openapiv3 json output format #37 from jimmystewpot/36-fix_hostname_regex
1a393c9 Fix hostname validation regexp
6cf224c Fixes issues related to swagger-specific rules with array schemas and items.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

gautierdelorme

Thanks! go.mod looks good now 👍

nikhita · 2020-11-05T11:18:00Z

/lgtm

I can merge this manually once @dims gives a thumbs up with his sig-arch hat on. :)

dims · 2020-11-05T11:25:26Z

/approve
/lgtm

k8s-ci-robot · 2020-11-05T11:25:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, gautierdelorme, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

nikhita · 2020-11-05T11:42:53Z

Manually merging since we've preserved git history, copyright headers and the licenses. See discussion at https://kubernetes.slack.com/archives/C0EG7JC6T/p1604575860477400?thread_ts=1592287631.273100&cid=C0EG7JC6T

casualjim and others added 30 commits September 28, 2017 09:00

Merge pull request kubernetes#33 from morlay/master

48c2a71

marshal unmarshal item of parameter with vendorExtensible

ref resolution

00fbf1c

remove debug artifact

78d12de

added tests

4762da7

fix basePath and add some logging

d9e0070

solve recursive issue

778dc9b

Merge pull request kubernetes#35 from kreamyx/ref-resolution

84b5bee

Reference Resolution

Fix panic when json.Number value is in a string field

e291569

Fixes kubernetes#33

Add the test case causing the (fixed) panic

4566af4

check that any object with items key should have a type array

e8b25c4

added tests

b6cfc35

added a check that type array must have items

e9896c1

Add Example field to SimpleSchema

eef1d9a

Merge pull request kubernetes#37 from ethantkoenig/example

a4fa957

Add Example field to SimpleSchema

Fix panic for nil schema

32c2d07

When the input schema is nil, `NewSchemaValidator` will return a nil `*SchemaValidator`. This nil `*SchemaValidator` is passed to `Validate`, which panics when `s.validators` is called.

more validations when type does not even exist

a762d5d

allow a property name to be items

bed0b99

remove debug artefact

9ca207c

allow a property name to be properties

a52193a

Recognize path parameters in path segment fragments kubernetes#39

d509235

Don't drop empty arrays of operations security definitions

58f1853

Fixes go-swagger/go-swagger#1281

Merge pull request kubernetes#39 from databus23/patch-1

bfb48d3

Don't drop empty arrays of operations security definitions

Merge pull request kubernetes#40 from databus23/regression-issue-39

5a4a1e9

Avoid null value when serializing operations

optimization of ResolveRef during code generation (kubernetes#41)

4a3d261

fixing paths for windows (kubernetes#42)

0173894

* fixing paths for windows * remove debugging artifacts

Consistently check if RelativeBase is empty

ae13823

Fixes kubernetes#43 Signed-off-by: Igor Zibarev <zibarev.i@gmail.com>

Merge pull request kubernetes#44 from hypnoglow/43-relative-base-checks

aa90e7c

Consistently check if RelativeBase is empty

Fix expandSchema when basePath is empty

6ef9882

Fixes kubernetes#45 Signed-off-by: Igor Zibarev <zibarev.i@gmail.com>

sttts added 8 commits November 5, 2020 10:51

pkg/validation: adapt imports

c8c0761

pkg/validation: strip spec package

73fa09a

pkg/validation: strip strfmt package

d3e34b6

pkg/validation: strip validate package

cc84d3c

pkg/validation: strip errors package

12b99a1

pkg/validation/validate: delete misplaced $schema and id logic

810b3bd

pkg/validation/validate: remove Swagger specific options

7c24206

pkg/validation: disconnect from mongo libraries

2feab02

sttts force-pushed the sttts-go-openapi branch from 98df15e to e65257f Compare November 5, 2020 09:51

k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 5, 2020

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 5, 2020

gautierdelorme reviewed Nov 5, 2020

View reviewed changes

sttts added 2 commits November 5, 2020 10:59

pkg/validation: revert github.com/go-openapi/validate/pull/81

6d4b372

We had contributed this upstream, but never used it due to structural schemas.

pkg/validation: remove yaml dependency

f11f208

sttts force-pushed the sttts-go-openapi branch 2 times, most recently from f032082 to fc7f497 Compare November 5, 2020 10:06

go mod tidy

79abcd8

sttts force-pushed the sttts-go-openapi branch from fc7f497 to 79abcd8 Compare November 5, 2020 10:15

gautierdelorme reviewed Nov 5, 2020

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2020

k8s-ci-robot assigned dims Nov 5, 2020

nikhita merged commit e58175e into kubernetes:master Nov 5, 2020

nikhita mentioned this pull request Nov 17, 2020

Host stable/kube-state-metrics helm chart kubernetes/kube-state-metrics#1237

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fork github.com/go-openapi/{spec,validate,errors,strfmt} #211

Fork github.com/go-openapi/{spec,validate,errors,strfmt} #211

sttts commented Oct 28, 2020 •

edited

Loading

k8s-ci-robot commented Nov 5, 2020

gautierdelorme left a comment

gautierdelorme Nov 5, 2020

gautierdelorme Nov 5, 2020

gautierdelorme Nov 5, 2020

gautierdelorme Nov 5, 2020

gautierdelorme Nov 5, 2020

k8s-ci-robot commented Nov 5, 2020

gautierdelorme left a comment

nikhita commented Nov 5, 2020

dims commented Nov 5, 2020

k8s-ci-robot commented Nov 5, 2020

nikhita commented Nov 5, 2020

Fork github.com/go-openapi/{spec,validate,errors,strfmt} #211

Fork github.com/go-openapi/{spec,validate,errors,strfmt} #211

Conversation

sttts commented Oct 28, 2020 • edited Loading

k8s-ci-robot commented Nov 5, 2020

gautierdelorme left a comment

Choose a reason for hiding this comment

gautierdelorme Nov 5, 2020

Choose a reason for hiding this comment

gautierdelorme Nov 5, 2020

Choose a reason for hiding this comment

gautierdelorme Nov 5, 2020

Choose a reason for hiding this comment

gautierdelorme Nov 5, 2020

Choose a reason for hiding this comment

gautierdelorme Nov 5, 2020

Choose a reason for hiding this comment

k8s-ci-robot commented Nov 5, 2020

gautierdelorme left a comment

Choose a reason for hiding this comment

nikhita commented Nov 5, 2020

dims commented Nov 5, 2020

k8s-ci-robot commented Nov 5, 2020

nikhita commented Nov 5, 2020

sttts commented Oct 28, 2020 •

edited

Loading