Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2: Rename collector to resource #1006

Merged
merged 7 commits into from
Feb 10, 2020
Merged

v2: Rename collector to resource #1006

merged 7 commits into from
Feb 10, 2020

Conversation

Alexander-Carpenter
Copy link
Contributor

What this PR does / why we need it: Rename collector to resource since the collet type pattern is no longer used.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #980

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 14, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @Alexander-Carpenter!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 14, 2019
@tariq1890 tariq1890 changed the title Rename collector to resource v2: Rename collector to resource Dec 17, 2019
@tariq1890 tariq1890 added the v2 version 2 label Dec 17, 2019
@Alexander-Carpenter
Copy link
Contributor Author

/assign @brancz

tariq1890
tariq1890 reviewed Jan 24, 2020
View reviewed changes
docs/cli-arguments.md Outdated Show resolved Hide resolved
lilic
lilic reviewed Jan 30, 2020
View reviewed changes
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase your branch and it seems like the tests are complaining about the docs file not being correct, can you double check this. You can run those tests locally as well.

Thanks!

@lilic
Copy link
Member

lilic commented Feb 5, 2020

@Alexander-Carpenter friendly ping in case you missed it :)

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 5, 2020
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 6, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 6, 2020
@Alexander-Carpenter
Copy link
Contributor Author

Sorry had an issue with rebase so recommited the changes

lilic
lilic reviewed Feb 6, 2020
View reviewed changes
pkg/options/options.go Outdated Show resolved Hide resolved
lilic
lilic approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Alexander-Carpenter, LiliC

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8dc870e into kubernetes:master Feb 10, 2020
This was referenced Feb 26, 2020
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tariq1890 tariq1890 tariq1890 left review comments

@lilic lilic lilic approved these changes

@andyxning andyxning Awaiting requested review from andyxning

@zouyee zouyee Awaiting requested review from zouyee

Assignees

@brancz brancz

@lilic lilic

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. v2 version 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2: Rename collector to resources
5 participants
@Alexander-Carpenter @k8s-ci-robot @lilic @tariq1890 @brancz