-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: --resources replaced with --collectors in the CLI #1059
Conversation
This is related to kubernetes#915
Welcome @stigok! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @stigok! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stigok, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tariq1890 PR #1080 and its twin #915 made me look again at this PR... |
Oh yes, thanks so much for catching this mistake @olivierlemasle. I will make the corrections. |
@olivierlemasle lol. Now I understand. git blame sent me here #1006 So how did I come about creating this PR? It was indeed because |
@stigok That’s a fair ask. We should update the README about breaking changes in master |
This is related to #915
What this PR does / why we need it:
It corrects invalid arguments used in the docs.