Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: --resources replaced with --collectors in the CLI #1059

Merged
merged 1 commit into from
Feb 16, 2020

Conversation

stigok
Copy link
Contributor

@stigok stigok commented Feb 14, 2020

This is related to #915

What this PR does / why we need it:
It corrects invalid arguments used in the docs.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 14, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @stigok!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 14, 2020
Copy link
Contributor

@tariq1890 tariq1890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2020
@tariq1890
Copy link
Contributor

Thanks @stigok!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stigok, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit 392572e into kubernetes:master Feb 16, 2020
@stigok stigok deleted the patch-1 branch February 16, 2020 23:56
@olivierlemasle
Copy link
Member

@tariq1890 PR #1080 and its twin #915 made me look again at this PR...
It's should be the opposite, right? Collectors have been renamed to resources with #1006, and documentation had already been updated to reflect this change. This PR actually reverts documentation to the old name.

@tariq1890
Copy link
Contributor

Oh yes, thanks so much for catching this mistake @olivierlemasle. I will make the corrections.

@stigok
Copy link
Contributor Author

stigok commented Feb 28, 2020

@olivierlemasle lol. Now I understand. git blame sent me here #1006

So how did I come about creating this PR? It was indeed because --resources didn't work, but --collectors did. My confusion stems from you merging v2 changes into master without bumping version. It could be nice to put up a warning about master being used to builld v2 in the readme :)

@tariq1890
Copy link
Contributor

@stigok That’s a fair ask. We should update the README about breaking changes in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants