-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README: revert to --resources and mention v2 #1085
Conversation
This reverts commit f5fbb55.
/assign @tariq1890 |
Thanks @olivierlemasle :). Left a few comments |
Thanks @tariq1890 for the quick review! I've updated the PR with your corrections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olivierlemasle, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
--resources
by--collectors
. Collectors have been renamed resources in v2: Rename collector to resource #1006.Which issue(s) this PR fixes :
N/A