Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into release-2.0 branch #1285

Merged
merged 43 commits into from
Oct 28, 2020

Conversation

lilic
Copy link
Member

@lilic lilic commented Oct 27, 2020

k8s-ci-robot and others added 30 commits October 7, 2020 01:28
Signed-off-by: Joel Whittaker-Smith <jdws.dev@gmail.com>
Fixed linting issues

Code review changes

Removed condition label from kube_job_status_failed metric

Removed condition label from Job Metrics
…ailed_reason

Added the job failure reason in kube_job_status_failed metric
Makefile: Override Commit in cloudbuild
Also change variable style for BuildDate to match the others
Migrate ingress and certificates away from deprecated APIs
Adds a new metrics to provide claimRef information to Prometheus. In
tracking down lingering PVs, it would be of interest to know where the
PV came from. With the claimRef information, it is easier to track down
the resource owners and inform that they have unclaimed PVs lingering
around.

Main motivation is that PVs cost money at cloud providers, if PVs stick
around for long, the costs might increase significantly.
…olume_claimref

feat(persistentvolume): claimRef info to labels
Improving readability and introducing type safety with external tools
like kubeval.

I needed to make change the import to an absolute one, but instead
rather removed the import to begin with, as we're getting rid of ksonnet
for most things now anyway.
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 27, 2020
@brancz
Copy link
Member

brancz commented Oct 28, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, lilic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9862ba2 into kubernetes:release-2.0 Oct 28, 2020
@lilic lilic deleted the merge-master-2.0 branch October 28, 2020 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.