Revert boskos client changes

[alvaroaleman]

/assign @ixdy
/cc @stevekuznetsov

[ixdy]

/hold

I'd like to see if there's a quick and easy way to roll-forward with the CRD config changes first.

[fejta]

/hold

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, fejta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• boskos/OWNERS [fejta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ixdy]

The issue is when we upgrade an existing deployment; the existing CRDs use ResourceCollection and DRLCCollection for the listKinds, while the new code uses ResourceObjectList and DRLCObjectList, and so the caching client fails to initialize properly:

E0212 22:31:57.049418       1 reflector.go:125] external/io_k8s_client_go/tools/cache/reflector.go:98: Failed to list *crds.DRLCObject: no kind "DRLCCollection" is registered for version "boskos.k8s.io/v1" in scheme "pkg/runtime/scheme.go:101"
E0212 22:31:57.803985       1 reflector.go:125] external/io_k8s_client_go/tools/cache/reflector.go:98: Failed to list *crds.ResourceObject: no kind "ResourceCollection" is registered for version "boskos.k8s.io/v1" in scheme "pkg/runtime/scheme.go:101"
{"component":"boskos","error":"timeout waiting for cache sync","file":"boskos/cmd/boskos/boskos.go:96","func":"main.main","level":"fatal","msg":"unable to get client","time":"2020-02-12T22:31:57Z"}

From some simple local experiments, I think it's possible to update the listKinds in the CRD specs without affecting the existing CRs. Maybe it would be worth extracting the CRD specs from the code (into separate YAML specs that can be applied) so that we can easily update the specs at the same time we update the code?

[ixdy]

We definitely can't roll forward without #16270, but I think #16267 works otherwise.

[ixdy]

/close

We've fixed the issue by pulling the CRDs out of boskos code and then updating and applying them to the cluster.

[k8s-ci-robot]

@ixdy: Closed this PR.

In response to this:

/close

We've fixed the issue by pulling the CRDs out of boskos code and then updating and applying them to the cluster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@alvaroaleman: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.