Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Boskos CRDs to prow/cluster, and bump Boskos back to latest #16267

Merged
merged 2 commits into from
Feb 13, 2020

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Feb 13, 2020

This is a revert of #16260, along with the required config changes so that Boskos hopefully won't crash.

This goes along with #16266, but it shouldn't be necessary to wait for it, since Boskos is not supposed to do anything if the CRDs already exist.

/hold
because I'm still validating these changes (and also we shouldn't merge this late in the day)

/assign @fejta
cc @alvaroaleman

/area boskos

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2020
@k8s-ci-robot k8s-ci-robot added area/boskos Issues or PRs related to code in /boskos cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow area/prow/bump Updates to the k8s prow cluster sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 13, 2020
@ixdy ixdy force-pushed the boskos-crd-update branch 2 times, most recently from be42bc2 to c5eae7a Compare February 13, 2020 00:35
@ixdy
Copy link
Member Author

ixdy commented Feb 13, 2020

Testing this locally in kind, this seems to do the right thing for the CRDs, but it seems like boskos is now failing to start for a different reason:

{"component":"boskos","error":"listen tcp :8080: bind: address already in use","file":"prow/interrupts/interrupts.go:156","func":"k8s.io/test-infra/prow/interrupts.ListenAndServe.func1","level":"info","msg":"Server exited.","time":"2020-02-13T01:31:20Z"}

@ixdy
Copy link
Member Author

ixdy commented Feb 13, 2020

Something is causing prometheus to serve metrics for rest_client_request_duration_seconds on port 8080. Still investigating...

@ixdy
Copy link
Member Author

ixdy commented Feb 13, 2020

We definitely can't roll forward without #16270, but I think this change would work otherwise.

@ixdy
Copy link
Member Author

ixdy commented Feb 13, 2020

Updated boskos to v20200213-7790e5cec. This includes #16270 and #16271. I think this works.

@matthyx
Copy link
Contributor

matthyx commented Feb 13, 2020

/cc @alvaroaleman

@alvaroaleman
Copy link
Member

Yeah saw it, I want us (openshift) to do it first, because there I can see logs if something goes south again. Will lgtm once that was successful

@alvaroaleman
Copy link
Member

Yup, works fine with the CRD update. Does bazel do that automatically if you just add the file?
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2020
@alvaroaleman
Copy link
Member

And thanks a lot for taking care here @ixdy

@fejta
Copy link
Contributor

fejta commented Feb 13, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit a5cd86a into kubernetes:master Feb 13, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 13, 2020
@fejta
Copy link
Contributor

fejta commented Feb 13, 2020

Looks like it isn't crash looping

@ixdy
Copy link
Member Author

ixdy commented Feb 13, 2020

Monitoring appears to be working again too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/boskos Issues or PRs related to code in /boskos area/prow/bump Updates to the k8s prow cluster area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants