-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Boskos CRDs to prow/cluster, and bump Boskos back to latest #16267
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ixdy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
be42bc2
to
c5eae7a
Compare
Testing this locally in kind, this seems to do the right thing for the CRDs, but it seems like boskos is now failing to start for a different reason:
|
Something is causing prometheus to serve metrics for |
We definitely can't roll forward without #16270, but I think this change would work otherwise. |
c5eae7a
to
f56e6f6
Compare
/cc @alvaroaleman |
Yeah saw it, I want us (openshift) to do it first, because there I can see logs if something goes south again. Will lgtm once that was successful |
Yup, works fine with the CRD update. Does bazel do that automatically if you just add the file? |
And thanks a lot for taking care here @ixdy |
/hold cancel |
Looks like it isn't crash looping |
Monitoring appears to be working again too. |
This is a revert of #16260, along with the required config changes so that Boskos hopefully won't crash.
This goes along with #16266, but it shouldn't be necessary to wait for it, since Boskos is not supposed to do anything if the CRDs already exist.
/hold
because I'm still validating these changes (and also we shouldn't merge this late in the day)
/assign @fejta
cc @alvaroaleman
/area boskos