Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boskos: disable controller-runtime manager metrics #16270

Merged

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Feb 13, 2020

The controller-runtime manager enables its own metrics serving by default on port 8080. This conflicts with the boskos server itself.

We probably don't need these metrics (at least not yet), so let's just disable them.

Follow-on to #16249.
x-ref #16267 (comment)

/assign @alvaroaleman @stevekuznetsov

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 13, 2020
@k8s-ci-robot k8s-ci-robot added area/boskos Issues or PRs related to code in /boskos sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2020
@alvaroaleman
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6bb357d into kubernetes:master Feb 13, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 13, 2020
@alvaroaleman
Copy link
Member

Interesting, I didn't notice this when I played around because the viper config reloading stuff seems to block forever when calling boskos with an empty config:

$ /tmp/boskos --namespace=default --log-level=debug -dynamic-resource-update-period=0 -kubeconfig=$KUBECONFIG -config="" 
{"component":"boskos","file":"/home/alvaro/git/work/test-infra/boskos/crds/client.go:134","func":"k8s.io/test-infra/boskos/crds.(*KubernetesClientOptions).CacheBackedClient","level":"info","msg":"Cache synced","sync-duration":"100.484959ms","time":"2020-02-13T09:07:27+01:00"}
{"component":"boskos","file":"/home/alvaro/git/work/test-infra/boskos/cmd/boskos/boskos.go:103","func":"main.main","level":"info","msg":"Created storage","time":"2020-02-13T09:07:27+01:00"}
2020/02/13 09:07:27 error: Config File "config" Not Found in "[]"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/boskos Issues or PRs related to code in /boskos cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants