Bug 2096780: Template Auth SSH Service

[upalatucci]

📝 Description

Adding secret selection in template scripts tab

🎥 Demo

[openshift-ci]

@upalatucci: This pull request references Bugzilla bug 2096780, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.12.0) matches configured target release for branch (4.12.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2096780: Template Auth SSH Service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@upalatucci: This pull request references Bugzilla bug 2096780, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.12.0) matches configured target release for branch (4.12.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2096780: Template Auth SSH Service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@upalatucci: This pull request references Bugzilla bug 2096780, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.12.0) matches configured target release for branch (4.12.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2096780: Template Auth SSH Service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yaacov]

/lgtm

next steps:
a - show only secrets that have sshkey data
b - allow to create a new secret is tricky, you will need to solve:
- secret can't be used on a different namespace (so you can't use it when creating a vm on different namespace)
- secret can't be automatically deleted when template is deleted, because some vm may use it

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upalatucci, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [yaacov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@upalatucci: All pull requests linked via external trackers have merged:

• kubevirt-ui/kubevirt-plugin#676

Bugzilla bug 2096780 has been moved to the MODIFIED state.

In response to this:

Bug 2096780: Template Auth SSH Service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.