-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2096780: Add Sysprep in template Objects array #815
Bug 2096780: Add Sysprep in template Objects array #815
Conversation
@upalatucci: This pull request references Bugzilla bug 2096780, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3802acb
to
19628bc
Compare
@upalatucci: This pull request references Bugzilla bug 2096780, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
19628bc
to
0875d6c
Compare
Thanks @metalice fixed |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@upalatucci: All pull requests linked via external trackers have merged:
Bugzilla bug 2096780 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
📝 Description
Currently, the template can only be attached to an existing Sysprep config in the same namespace.
Now we can add it to the template objects array.
Users can choose between creating a new one every time the template is used or attaching the template to an existing Sysprep config.
Same thing can be done for ssh keys and ssh services
🎥 Demo