Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2096780: Add Sysprep in template Objects array #815

Conversation

upalatucci
Copy link
Member

@upalatucci upalatucci commented Aug 5, 2022

📝 Description

Currently, the template can only be attached to an existing Sysprep config in the same namespace.
Now we can add it to the template objects array.

Users can choose between creating a new one every time the template is used or attaching the template to an existing Sysprep config.

Same thing can be done for ssh keys and ssh services

🎥 Demo

Screenshot from 2022-08-05 11-18-42
Screenshot from 2022-08-05 11-18-35

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2022

@upalatucci: This pull request references Bugzilla bug 2096780, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2096780: Add Sysprep in template Objects array

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gouyang August 5, 2022 09:20
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2022

@upalatucci: This pull request references Bugzilla bug 2096780, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2096780: Add Sysprep in template Objects array

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@upalatucci
Copy link
Member Author

Thanks @metalice fixed

@metalice
Copy link
Member

metalice commented Aug 8, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Aug 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Aug 8, 2022
@openshift-merge-robot openshift-merge-robot merged commit 5b3bb03 into kubevirt-ui:main Aug 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2022

@upalatucci: All pull requests linked via external trackers have merged:

Bugzilla bug 2096780 has been moved to the MODIFIED state.

In response to this:

Bug 2096780: Add Sysprep in template Objects array

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-medium bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants