-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2096780: Wizard Sysprep modal with existing sysprep selection #682
Conversation
@upalatucci: This pull request references Bugzilla bug 2096780, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@upalatucci: This pull request references Bugzilla bug 2096780, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
a58481d
to
e49f5f4
Compare
/lgtm text may be nicer "sysprep" -> "sysprep configMap" or "sysprep configuration" ? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: upalatucci, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yes, agree. I would go for "sysprep configuration" |
@upalatucci: All pull requests linked via external trackers have merged: Bugzilla bug 2096780 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
📝 Description
Sysprep modal with sysprep selection.
Follow-up pr will enable sysprep selection in template scripts tab
🎥 Demo