-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nil pointer dereference in pkg/operator/controller/cruft.go #2852
Labels
Comments
maya-r
added a commit
to maya-r/containerized-data-importer
that referenced
this issue
Aug 21, 2023
Seen in practice when deleting CDI CR in issue kubevirt#2852 Signed-off-by: Maya Rashish <mrashish@redhat.com>
kubevirt-bot
pushed a commit
that referenced
this issue
Aug 22, 2023
Seen in practice when deleting CDI CR in issue #2852 Signed-off-by: Maya Rashish <mrashish@redhat.com>
kubevirt-bot
pushed a commit
to kubevirt-bot/containerized-data-importer
that referenced
this issue
Aug 22, 2023
Seen in practice when deleting CDI CR in issue kubevirt#2852 Signed-off-by: Maya Rashish <mrashish@redhat.com>
maya-r
added a commit
to maya-r/containerized-data-importer
that referenced
this issue
Aug 22, 2023
Seen in practice when deleting CDI CR in issue kubevirt#2852 Signed-off-by: Maya Rashish <mrashish@redhat.com>
kubevirt-bot
pushed a commit
that referenced
this issue
Aug 22, 2023
Seen in practice when deleting CDI CR in issue #2852 Signed-off-by: Maya Rashish <mrashish@redhat.com>
kubevirt-bot
added a commit
that referenced
this issue
Aug 22, 2023
Seen in practice when deleting CDI CR in issue #2852 Signed-off-by: Maya Rashish <mrashish@redhat.com> Co-authored-by: Maya Rashish <mrashish@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened:
cdi-operator crashes if the CDI CR is missing or in error state.
What you expected to happen:
No crash
How to reproduce it (as minimally and precisely as possible):
Delete the CDI CR?
Additional context:
in pkg/operator/controller/cruft.go,
watchCDICRD()
callsGetActiveCDI()
which can returnnil, nil
, and then dereferences the first value if the second is nilEnvironment:
app.kubernetes.io/version: 4.13.3
The text was updated successfully, but these errors were encountered: