Tolerate GetActiveCDI returning nil, nil #2856
Conversation
Seen in practice when deleting CDI CR in issue kubevirt#2852 Signed-off-by: Maya Rashish <mrashish@redhat.com>
kubevirt-bot
added
release-note
|
/cherry-pick release-v1.57 |
|
@maya-r: once the present PR merges, I will cherry-pick it on top of release-v1.57 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Nice! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akalenyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
@maya-r: new pull request created: #2857 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Seen in practice when deleting CDI CR in issue #2852
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2852
Special notes for your reviewer:
Surprisingly, when testing the code locally, cdi-operator was running and happy, with one restart.
I think the code in cruft.go is run infrequently, so perhaps I shouldn't burden our tests with trying hard to trigger it.
Release note: