Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.56] Tolerate GetActiveCDI returning nil, nil #2858

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

maya-r
Copy link
Contributor

@maya-r maya-r commented Aug 22, 2023

Seen in practice when deleting CDI CR in issue #2852

What this PR does / why we need it:
Manual backport of #2856 for release-v1.56, resolving a conflict manually.

Release note:

Avoid crash of cdi-operator when CDI CR is deleted

Seen in practice when deleting CDI CR in issue kubevirt#2852

Signed-off-by: Maya Rashish <mrashish@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 22, 2023
@maya-r maya-r changed the title Tolerate GetActiveCDI returning nil, nil [release-v1.56] Tolerate GetActiveCDI returning nil, nil Aug 22, 2023
@akalenyu
Copy link
Collaborator

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akalenyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2023
@alromeros
Copy link
Collaborator

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2023
@kubevirt-bot kubevirt-bot merged commit f57ee9b into kubevirt:release-v1.56 Aug 22, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants