fix: sort services by name #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Deploying with
|
| Latest commit: |
7f3f251
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://126590ca.kurtosis-docs.pages.dev |
| Branch Preview URL: | https://gyani-sort-by-name.kurtosis-docs.pages.dev |
gbouv
approved these changes
Mar 10, 2023
leoporoli
pushed a commit
that referenced
this pull request
Mar 13, 2023
🤖 I have created a release *beep* *boop* --- ## [0.68.7](0.68.6...0.68.7) (2023-03-13) ### Bug Fixes * added instruction position while executing starlark package ([bc70e4e](bc70e4e)) * added instruction position while executing starlark package ([#143](#143)) ([bc70e4e](bc70e4e)) * fix changelog for versioned docs going forward ([#142](#142)) ([2fc3e72](2fc3e72)) * gramatical fix in analytics tracking logging ([#138](#138)) ([23212a3](23212a3)) * sort services by name ([#139](#139)) ([d60ef67](d60ef67)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we currently sort by uuid, so my-nginx-0, my-nginx-2 and my-nginx-1 might get sorted in the wrong order. This sorts by name which is similar to how things were sorted before we went from GUID (service-id-timestamp) to UUID (hex string)
Note, services aren't still sorted by creation time as they never were. That would be a result of #135