feat: Added service readiness check in add_service and add_services instructions, through the ServiceConfig.ReadyConditions field
#148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbouv
approved these changes
Mar 17, 2023
...erver/api_container/server/startosis_engine/kurtosis_instruction/add_service/add_services.go
Show resolved
Hide resolved
...erver/api_container/server/startosis_engine/kurtosis_instruction/add_service/add_services.go
Show resolved
Hide resolved
...api_container/server/startosis_engine/kurtosis_instruction/shared_helpers/service_helpers.go
Outdated
Show resolved
Hide resolved
...api_container/server/startosis_engine/kurtosis_instruction/shared_helpers/service_helpers.go
Outdated
Show resolved
Hide resolved
...api_container/server/startosis_engine/kurtosis_instruction/shared_helpers/service_helpers.go
Outdated
Show resolved
Hide resolved
...api_container/server/startosis_engine/kurtosis_instruction/shared_helpers/service_helpers.go
Outdated
Show resolved
Hide resolved
...erver/startosis_engine/kurtosis_starlark_framework/test_engine/add_service_framework_test.go
Show resolved
Hide resolved
...rver/startosis_engine/kurtosis_starlark_framework/test_engine/add_services_framework_test.go
Show resolved
Hide resolved
|
BTW why is this a breaking change?? Aren't the readiness checks optional after all? |
|
@gbouv yes it's not a breaking change, but it depends on the code that is in the breaking change branch now, which is not having the |
leoporoli
force-pushed
the
lporoli/740
branch
2 times, most recently
from
3c61e5c to
a28e1cd
Compare
|
Do we have some docs on this @leoporoli ? This feels user-facing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog picked up from commits here:
build(deps): bump github.com/docker/distribution from 2.7.1+incompatible to 2.8.0+incompatible in /core/server (#114)
build(deps): bump github.com/docker/distribution in /core/server
build(deps): bump github.com/opencontainers/image-spec from 1.0.1 to 1.0.2 in /core/server (#113)
build(deps): bump github.com/opencontainers/image-spec in /core/server
docs: add onboarding calendly links to docs (#14)
docs: create guide on installing historical versions (#131)
fix: fix changelog for versioned docs going forward (#142)
docs: pruned versions 0.68.1, 0.68.3 & 0.68.4 as the binaries were
docs: added changelog to 0.68.2, 0.68.5 & 0.68.6
docs: ignore docs built by docusaurus in docs checker (#141)
fix: sort services by name (#139)
fix: gramatical fix in analytics tracking logging (#138)
docs: Minify README language (#107)
chore(main): release 0.68.6 (#132)
docs: add kurtosis feedback cli command (#53)
feat: Added
kurtosis feedbackCLI command (#28)docs: Simplify the docs landing page with latest "distribution application development platform" language (#110)
feat: publish versioned brew formula (#130)
build: Stop publishing go module to a separate repository (#124)
chore(main): release 0.68.5 (#128)
fix: Use version.txt for kurtosis_version instead of Git tags (#126)
chore(main): release 0.68.4 (#123)
fix: Pass correct latest tag to GoReleaser CLI build (#122)
chore(main): release 0.68.3 (#121)
feat: Use semver versioning for Golang API package (#119)
docs: remove WARN level log lines in readme (#112)
docs: add questions+help+feedback links (#111)
fix: remove mentions about github discussions (#95)
chore(main): release 0.68.2 (#120)
fix: fix push_cli_artifacts ci job (#118)
chore(main): release 0.68.1 (#115)
ci: fix push docs ci (#116)
feat: docs are versioned (#106)
refactor: remove dependence on private free ip address provider (#108)
refactor: Migrate IP Address and Hostname to runtime value (#100)
build(deps): bump golang.org/x/net from 0.0.0-20210913180222-943fd674d43e to 0.7.0 in /internal_testsuites/golang (#72)
build(deps): bump golang.org/x/net in /internal_testsuites/golang
docs: Fix NGINX port in quickstart (#109)
chore(main): release 0.68.0 (#102)
refactor!: Migrate Kurtosis Print instruction to Starlark framework. This restrict the use of
printto a single argument only. (#80) (#87)docs: fix a typo in exec assert example (#103)
docs: Add LICENSE (#99)
feat: enclave clean has both name and uuid (#101)
refactor: Migrate ConnectionConfig to Starlark Framework (#97)
refactor: Migrate packet delay distributions to Starlark Framework (#96)
refactor: Migrate PortSpec to Starlark Command Framework (#91)
feat: persist partition connection overrides to disk (#98)