Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: This is a breaking change where we are removing the ExecRecipe.service_name, GetHttpRequestRecipe.service_name, and PostHttpRequestRecipe.service_name fields, we suggest users pass this value as an argument in the exec, request and wait instructions where this type is currently used. We are also deprecating the previous exec, request, and wait instructions signature that haven't the service_name field, users must add this field on these instructions call. Another change is that now the service_name field on the exec, request, and wait instructions is mandatory. (#93) #297

Closed
wants to merge 50 commits into from

Conversation

leoporoli
Copy link
Contributor

@leoporoli leoporoli commented Mar 22, 2023

Description:

feat: Added ReadyConditions type which is used in ServiceConfig for defining how to check services readiness

Is this change user facing?

YES

References (if applicable):

Fixes https://github.com/kurtosis-tech/kurtosis-private/issues/740

Changelog picked up from commits here:

docs: Added ReadyConditions type documentation (#249)
docs: Remove broken docs links (#258)
feat: Added service readiness check in add_service and add_services instructions, through the ServiceConfig.ReadyConditions field (#148)
feat: Added ReadyConditions type which is used in ServiceConfig for defining how to check services readiness (#151)
build(deps): bump github.com/docker/distribution from 2.7.1+incompatible to 2.8.0+incompatible in /core/server (#114)
build(deps): bump github.com/docker/distribution in /core/server
build(deps): bump github.com/opencontainers/image-spec from 1.0.1 to 1.0.2 in /core/server (#113)
build(deps): bump github.com/opencontainers/image-spec in /core/server
docs: add onboarding calendly links to docs (#14)
docs: create guide on installing historical versions (#131)
fix: fix changelog for versioned docs going forward (#142)
docs: pruned versions 0.68.1, 0.68.3 & 0.68.4 as the binaries were
docs: added changelog to 0.68.2, 0.68.5 & 0.68.6
docs: ignore docs built by docusaurus in docs checker (#141)
fix: sort services by name (#139)
fix: gramatical fix in analytics tracking logging (#138)
docs: Minify README language (#107)
chore(main): release 0.68.6 (#132)
docs: add kurtosis feedback cli command (#53)
feat: Added kurtosis feedback CLI command (#28)
docs: Simplify the docs landing page with latest "distribution application development platform" language (#110)
feat: publish versioned brew formula (#130)
build: Stop publishing go module to a separate repository (#124)
chore(main): release 0.68.5 (#128)
fix: Use version.txt for kurtosis_version instead of Git tags (#126)
chore(main): release 0.68.4 (#123)
fix: Pass correct latest tag to GoReleaser CLI build (#122)
chore(main): release 0.68.3 (#121)
feat: Use semver versioning for Golang API package (#119)
docs: remove WARN level log lines in readme (#112)
docs: add questions+help+feedback links (#111)
fix: remove mentions about github discussions (#95)
chore(main): release 0.68.2 (#120)
fix: fix push_cli_artifacts ci job (#118)
chore(main): release 0.68.1 (#115)
ci: fix push docs ci (#116)
feat: docs are versioned (#106)
refactor: remove dependence on private free ip address provider (#108)
refactor: Migrate IP Address and Hostname to runtime value (#100)
build(deps): bump golang.org/x/net from 0.0.0-20210913180222-943fd674d43e to 0.7.0 in /internal_testsuites/golang (#72)
build(deps): bump golang.org/x/net in /internal_testsuites/golang
docs: Fix NGINX port in quickstart (#109)
chore(main): release 0.68.0 (#102)
refactor!: Migrate Kurtosis Print instruction to Starlark framework. This restrict the use of print to a single argument only. (#80) (#87)
docs: fix a typo in exec assert example (#103)
docs: Add LICENSE (#99)
feat: enclave clean has both name and uuid (#101)
refactor: Migrate ConnectionConfig to Starlark Framework (#97)
refactor: Migrate packet delay distributions to Starlark Framework (#96)
refactor: Migrate PortSpec to Starlark Command Framework (#91)
feat: persist partition connection overrides to disk (#98)

leoporoli and others added 30 commits March 6, 2023 11:22
…e.service_name`, `GetHttpRequestRecipe.service_name`, and `PostHttpRequestRecipe.service_name` fields, we suggest users pass this value as an argument in the `exec`, `request` and `wait` instructions where this type is currently used. We are also deprecating the previous `exec`, `request`, and `wait` instructions signature that haven't the `service_name` field, users must add this field on these instructions call. Another change is that now the `service_name` field on the `exec`, `request`, and `wait` instructions is mandatory. (#93)

* Added service name in exec

* Added new exec signature

* Refactored wait instructions and http recipe

* request instruction refactore

* Added deprecation warning in the recipes

* recipe.service_name field now is optional

* Addind the docs

* Changed service name position for exec instruction

* Changed service name position for request and wait instructions

* Fixed linter problems

* Refactored TestStartosisInterpreter_InvalidExecRecipeMissingRequiredServiceName

* Fixed test

* Finished the docs

* Added info about deprecation

* changes after PR review

* changes in the documentation

* Removing service name from exec recipe

* Removed service_name field

* refactored test cases

* Fixed exec framework test case 2

* Turned service_name parameter in exec instruction mandatory

* Turned service_name parameter in request instruction mandatory

* Turned service_name parameter in wait instruction mandatory

* Renamed test cases

* Renamed a var

* Removed unused shared helper

* fixed test

* Fixed exec recipe on internal test suites

* Fixed internal tests

* mising space added
* added replace bucket contents for partition connections

* checkpointing work

* replace and get all seem alright

* added the add method

* things kinda work but need cleaning up

* use view instead of update

* have all the necessary primitives

* this should work

* some renaming

* this should work

* some more fixes

* put buckets in their own packages

* some mroe cleaning

* improve logging

* clean up some code

* removed some no-ops

* some more rework

* some more rewrites

* some more cleanup

* add comment on why upercased

* handle uuid and name

* worked on reviews

* some rework
* Migrate PortSpec to Starlark Command Framework

* Fix typo in comment
* Migrate packet delay distributions to Starlark Framework

* address PR comment
* Migrate packet delay distributions to Starlark Framework

* Migrate ConnectionConfig to Starlark Framework
* Add LICENSE

* Fix script bugs

* Add License update to Release please

---------

Co-authored-by: Victor Colombo <victor.colombo@kurtosistech.com>
…This restrict the use of `print` to a single argument only. (#80) (#87)

* refactor!: Migrate Kurtosis Print instruction to Starlark framework. This restrict the use of `print` to a single argument only. (#80)

Migrate Kurtosis Print instruction to starlark framework

* feat!: integrate nature theme name to upload command cli (#89)

* fixed the typo

---------

Co-authored-by: Peeeekay <15133250+Peeeekay@users.noreply.github.com>
* chore(main): release 0.68.0

* use -d instead of -v

* Apply automatic changes

---------

Co-authored-by: pk <15133250+Peeeekay@users.noreply.github.com>
Fix NGINX port in quickstart
…d43e to 0.7.0 in /internal_testsuites/golang (#72)

build(deps): bump golang.org/x/net in /internal_testsuites/golang

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.0.0-20210913180222-943fd674d43e to 0.7.0.
- [Release notes](https://github.com/golang/net/releases)
- [Commits](https://github.com/golang/net/commits/v0.7.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gyanendra Mishra <anomaly.the@gmail.com>
* Migrate IP Address and Hostname to runtime value

* Fix linter

* Fix ip bug

* Remove IP and Hostname specific code

---------

Co-authored-by: Victor Colombo <victor.colombo@kurtosistech.com>
* removed github-user and commented ci

* remove some unused code

* cleanup private repo stuff from Golang Ci Lint

* removed dependence on free ip address tracker

* removed useless git config settings
* docusaurus config adds versionoin

* Revert "docusaurus config adds versionoin"

This reverts commit 12089f6.

* dont use relative links

* added versiondropdown

* this should be it

* added a bunch of scripts

* add versioned docs

* use git instead of bash magic

* update the docs checker config to ignore site static links

* moved version to top right

* exclude all links starting with site

* remove trailing comma

* change the label for the current documentation version from Next to main
* chore(main): release 0.68.1

* fix change versions script

* fix bash further

* Apply automatic changes

* change things

* maybe this works

* change the depth

* this should work

---------

Co-authored-by: Gyanendra Mishra <anomaly.the@gmail.com>
Co-authored-by: h4ck3rk3y <h4ck3rk3y@users.noreply.github.com>
* chore(main): release 0.68.2

* Apply automatic changes

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
* fix: remove mentions about github discussions

- remove mentions about github discussions
- point folks to new github issue templates
- add our new email link
- encourage engagement via discord & calendly 1:1 sessions

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md
add questions+help+feedback links
* feature: Use semver versioning for Golang API package

* Add new line

* Fix env variable

* Do correct tagging

* Fix versioning

---------

Co-authored-by: Victor Colombo <victor.colombo@kurtosistech.com>
* chore(main): release 0.68.3

* Apply automatic changes

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
* Empty commit

* Pass current tag

---------

Co-authored-by: Victor Colombo <victor.colombo@kurtosistech.com>
* chore(main): release 0.68.4

* Apply automatic changes

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Co-authored-by: Victor Colombo <victor.colombo@kurtosistech.com>
* Stop publishing go module to a separate repository

* Remove mention to publish golang

---------

Co-authored-by: Victor Colombo <victor.colombo@kurtosistech.com>
* publish versioned brew formula

* fix owner of repo

* use tag var instead

* add license field
mieubrisse and others added 19 commits March 13, 2023 13:09
…ation development platform" language (#110)

Simplify home.md
Make the README starting section less wordy, and use our "distributed application development platform" category
gramatical fix in analytics tracking logging
Closes #134 

docs: pruned versions 0.68.1, 0.68.3 & 0.68.4 as the binaries were
broken / never released
docs: added changelog to 0.68.2, 0.68.5 & 0.68.6
* docs: add onboarding calendly links to docs

* docs: add onboarding links to quickstart

* docs: add onboarding calendly to our docs banner

* on-boarding --> onboarding

* on-boarding --> onboarding

* Update docs/docs/home.md
…1.0.2 in /core/server (#113)

Bumps
[github.com/opencontainers/image-spec](https://github.com/opencontainers/image-spec)
from 1.0.1 to 1.0.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/opencontainers/image-spec/releases">github.com/opencontainers/image-spec's
releases</a>.</em></p>
<blockquote>
<h2>v1.0.2</h2>
<p>This release was voted on by the maintainers and PASSED (+5 -0 <a
href="https://github-redirect.dependabot.com/opencontainers/image-spec/issues/2">#2</a>),
to mitigate the CVE-2021-41190 advisory.</p>
<p>This release is rebased directly on the prior tagged release (not
including the commits that have occurred on main). Corresponding commits
have been added to main, such that main is ready for a future next
release.</p>
<p><img
src="https://user-images.githubusercontent.com/67049/142260429-9da17e3d-c6dd-4721-89bb-0ef72ef69c22.gif"
alt="R" /></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/opencontainers/image-spec/commit/67d2d5658fe0476ab9bf414cec164077ebff3920"><code>67d2d56</code></a>
version: release 1.0.2</li>
<li><a
href="https://github.com/opencontainers/image-spec/commit/dcdcb7f2cf08641d03189e5b09be32de5dcfe459"><code>dcdcb7f</code></a>
specs-go: adding <code>mediaType</code> to the index and manifest
structures</li>
<li><a
href="https://github.com/opencontainers/image-spec/commit/5f3148525b82017cb470ff5f54b37aae4003eb07"><code>5f31485</code></a>
*.md: bring mediaType out of reserved status</li>
<li>See full diff in <a
href="https://github.com/opencontainers/image-spec/compare/v1.0.1...v1.0.2">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/opencontainers/image-spec&package-manager=go_modules&previous-version=1.0.1&new-version=1.0.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
-  will rebase this PR
- will recreate this PR, overwriting any edits that have been made to it
-  will merge this PR after your CI passes on it
-  will squash and merge this PR after your CI passes on it
-  will cancel a previously requested merge and block automerging
-  will reopen this PR if it is closed
- will close this PR and stop Dependabot recreating it. You can achieve
the same result by closing it manually
- will close this PR and stop Dependabot creating any more for this
major version (unless you reopen the PR or upgrade to it yourself)
- will close this PR and stop Dependabot creating any more for this
minor version (unless you reopen the PR or upgrade to it yourself)
- will close this PR and stop Dependabot creating any more for this
dependency (unless you reopen the PR or upgrade to it yourself)
- will set the current labels as the default for future PRs for this
repo and language
- will set the current reviewers as the default for future PRs for this
repo and language
- will set the current assignees as the default for future PRs for this
repo and language
- will set the current milestone as the default for future PRs for this
repo and language

You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/kurtosis-tech/kurtosis/network/alerts).

</details>

Changelog picked up from commits here:

build(deps): bump github.com/opencontainers/image-spec in /core/server

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Peeeekay <15133250+Peeeekay@users.noreply.github.com>
Co-authored-by: leoporoli <leandroporoli@gmail.com>
…ble to 2.8.0+incompatible in /core/server (#114)

Bumps
[github.com/docker/distribution](https://github.com/docker/distribution)
from 2.7.1+incompatible to 2.8.0+incompatible.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/docker/distribution/releases">github.com/docker/distribution's
releases</a>.</em></p>
<blockquote>
<h2>v2.8.0</h2>
<p>registry 2.8.0</p>
<p>Welcome to the v2.8.0 release of registry!</p>
<p>The 2.8.0 registry release has been a long time overdue.
This is the first step towards the last 2.x release.
No further active development will continue on 2.x branch.
Security vulnerability patches to 2.x might be considered, but
all active development will be focussed on v3 release due in 2022.
This release includes a security vulnerability fix along
with a few minor bug fixes and improvemnts in documentation and CI.</p>
<p>See changelog below for full list of changes.</p>
<h3>Bugfixes</h3>
<ul>
<li>Close the io.ReadCloser from storage driver <a
href="https://github-redirect.dependabot.com/distribution/distribution/pull/3370">#3370</a></li>
<li>Remove empty Content-Type header <a
href="https://github-redirect.dependabot.com/distribution/distribution/pull/3297">#3297</a></li>
<li>Make ipfilteredby not required in cloudfront storage middleware <a
href="https://github-redirect.dependabot.com/distribution/distribution/pull/3088">#3088</a></li>
</ul>
<h3>Features</h3>
<ul>
<li>Add reference.ParseDockerRef utility function <a
href="https://github-redirect.dependabot.com/distribution/distribution/pull/3002">#3002</a></li>
</ul>
<h3>CI build</h3>
<ul>
<li>First draft of actions based ci <a
href="https://github-redirect.dependabot.com/distribution/distribution/pull/3347">#3347</a></li>
<li>Fix vndr and check <a
href="https://github-redirect.dependabot.com/distribution/distribution/pull/3001">#3001</a></li>
<li>Improve code quality by adding linter checks <a
href="https://github-redirect.dependabot.com/distribution/distribution/pull/3385">#3385</a></li>
</ul>
<h3>Documentation</h3>
<ul>
<li>Add redirect for old URL <a
href="https://github-redirect.dependabot.com/distribution/distribution/pull/3197">#3197</a></li>
<li>Fix broken table <a
href="https://github-redirect.dependabot.com/distribution/distribution/pull/3073">#3073</a></li>
<li>Adding deprecated schema v1 instructions <a
href="https://github-redirect.dependabot.com/distribution/distribution/pull/2987">#2987</a></li>
<li>Change should to must in v2 spec (<a
href="https://github-redirect.dependabot.com/distribution/distribution/pull/3495">#3495</a>)</li>
</ul>
<h3>Storage drivers</h3>
<ul>
<li>S3 Driver: add support for ceph radosgw <a
href="https://github-redirect.dependabot.com/distribution/distribution/pull/3119">#3119</a></li>
</ul>
<h3>Security</h3>
<ul>
<li>Added flag for user configurable cipher suites <a
href="https://github-redirect.dependabot.com/distribution/distribution/pull/3384">#3384</a></li>
<li>Address <a
href="https://github.com/advisories/GHSA-w73w-5m7g-f7qc">CVE-2020-26160</a>
by replacing vulnerable third-party depedency<a
href="https://github-redirect.dependabot.com/distribution/distribution/pull/3466">#3466</a></li>
<li>Replace math rand with crypto rand <a
href="https://github-redirect.dependabot.com/distribution/distribution/pull/3531">#3531</a></li>
<li>Address <a
href="https://github.com/advisories/GHSA-mc8v-mgrf-8f4m">CVE-2021-41190</a>
by validating document type before unmarshal <a
href="https://github-redirect.dependabot.com/distribution/distribution-ghsa-qq97-vm5h-rrhg/pull/2">GHSA-77vh-xpmg-72qh</a></li>
</ul>
<h3>Changes</h3>
<!-- raw HTML omitted -->
<ul>
<li>Prepare for v2.8.0 release (<a
href="https://github-redirect.dependabot.com/distribution/distribution/pull/3552">#3552</a>)
<ul>
<li><a
href="https://github.com/distribution/distribution/commit/d5d89a46a388a1d35b3b9b9cd60515e45ac3a7d4"><code>d5d89a46</code></a>
Make this releaes a beta release first.</li>
<li><a
href="https://github.com/distribution/distribution/commit/1ddad0bad8c5e207904d9241ba2fb4557b27e1ed"><code>1ddad0ba</code></a>
Apply suggestions from code review</li>
</ul>
</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/distribution/distribution/commit/dcf66392d606f50bf3a9286dcb4bdcdfb7c0e83a"><code>dcf6639</code></a>
Update README so the release pipeline works properly.</li>
<li><a
href="https://github.com/distribution/distribution/commit/212b38ed225e42676c2a2e478aecc2b2fcc62fc9"><code>212b38e</code></a>
Merge pull request <a
href="https://github-redirect.dependabot.com/docker/distribution/issues/3552">#3552</a>
from milosgajdos/v2.8.0-release</li>
<li><a
href="https://github.com/distribution/distribution/commit/359b97a75a339af182e960fdabf6ade2e0474629"><code>359b97a</code></a>
Merge pull request <a
href="https://github-redirect.dependabot.com/docker/distribution/issues/3568">#3568</a>
from crazy-max/2.8-artifacts</li>
<li><a
href="https://github.com/distribution/distribution/commit/d5d89a46a388a1d35b3b9b9cd60515e45ac3a7d4"><code>d5d89a4</code></a>
Make this releaes a beta release first.</li>
<li><a
href="https://github.com/distribution/distribution/commit/6241e099e14dff2dd85a3bcd31cfcf9942dadc49"><code>6241e09</code></a>
[2.8] Release artifacts</li>
<li><a
href="https://github.com/distribution/distribution/commit/1840415ca85bc6d70106dccea1c13743e7d3b6fb"><code>1840415</code></a>
Merge pull request <a
href="https://github-redirect.dependabot.com/docker/distribution/issues/3565">#3565</a>
from crazy-max/2.8-gha</li>
<li><a
href="https://github.com/distribution/distribution/commit/65ca39e60558bf526de2b1f00bf75b0fdd898071"><code>65ca39e</code></a>
release workflow</li>
<li><a
href="https://github.com/distribution/distribution/commit/1ddad0bad8c5e207904d9241ba2fb4557b27e1ed"><code>1ddad0b</code></a>
Apply suggestions from code review</li>
<li><a
href="https://github.com/distribution/distribution/commit/3960a560bbb7a4e483da2d6f83158d18f9ab21f9"><code>3960a56</code></a>
Prepare for v2.8.0 release</li>
<li><a
href="https://github.com/distribution/distribution/commit/3b7b534569220c840993aad03e3eafe54b923f4d"><code>3b7b534</code></a>
Merge pull request from GHSA-qq97-vm5h-rrhg</li>
<li>Additional commits viewable in <a
href="https://github.com/docker/distribution/compare/v2.7.1...v2.8.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/docker/distribution&package-manager=go_modules&previous-version=2.7.1+incompatible&new-version=2.8.0+incompatible)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
-  will rebase this PR
- will recreate this PR, overwriting any edits that have been made to it
-  will merge this PR after your CI passes on it
-  will squash and merge this PR after your CI passes on it
-  will cancel a previously requested merge and block automerging
-  will reopen this PR if it is closed
- will close this PR and stop Dependabot recreating it. You can achieve
the same result by closing it manually
- will close this PR and stop Dependabot creating any more for this
major version (unless you reopen the PR or upgrade to it yourself)
- will close this PR and stop Dependabot creating any more for this
minor version (unless you reopen the PR or upgrade to it yourself)
- will close this PR and stop Dependabot creating any more for this
dependency (unless you reopen the PR or upgrade to it yourself)
- will set the current labels as the default for future PRs for this
repo and language
- will set the current reviewers as the default for future PRs for this
repo and language
- will set the current assignees as the default for future PRs for this
repo and language
- will set the current milestone as the default for future PRs for this
repo and language

You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/kurtosis-tech/kurtosis/network/alerts).

</details>

Changelog picked up from commits here:

build(deps): bump github.com/docker/distribution in /core/server

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: leoporoli <leandroporoli@gmail.com>
…or defining how to check services readiness (#151)
…s` instructions, through the `ServiceConfig.ReadyConditions` field (#148)
docs checker was failing because those repos are private. Topics
discussed here:
https://kurtosistech.slack.com/archives/C032ZB39AHH/p1679273010856589

<!-- A user facing change is one that you should expect a day-to-day
user to encounter or if the change requires user-action upon or before
upgrading. If in doubt, select "Yes" -->
* [ ] Yes
* [X] No

<!-- If yes, please add the  label to this Pull Request -->

<!-- Add relevant Github Issues, Discord threads, or other helpful
information. -->
@github-actions github-actions bot changed the title feat!: This is a breaking change where we are removing the ExecRecipe.service_name, GetHttpRequestRecipe.service_name, and PostHttpRequestRecipe.service_name fields, we suggest users pass this value as an argument in the exec, request and wait instructions where this type is currently used. We are also deprecating the previous exec, request, and wait instructions signature that haven't the service_name field, users must add this field on these instructions call. Another change is that now the service_name field on the exec, request, and wait instructions is mandatory. feat!: This is a breaking change where we are removing the ExecRecipe.service_name, GetHttpRequestRecipe.service_name, and PostHttpRequestRecipe.service_name fields, we suggest users pass this value as an argument in the exec, request and wait instructions where this type is currently used. We are also deprecating the previous exec, request, and wait instructions signature that haven't the service_name field, users must add this field on these instructions call. Another change is that now the service_name field on the exec, request, and wait instructions is mandatory. (#93) Mar 22, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 22, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f35e743
Status: ✅  Deploy successful!
Preview URL: https://ceec754b.kurtosis-docs.pages.dev
Branch Preview URL: https://2023-03-22-breaking-release.kurtosis-docs.pages.dev

View logs

@leoporoli
Copy link
Contributor Author

Closing it because it was merged here: #301

@leoporoli leoporoli closed this Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants