Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add initial SDK library boilerplate and basic svelte LD SDK #632

Merged
merged 17 commits into from
Dec 19, 2024

Conversation

nosnibor89
Copy link
Contributor

@nosnibor89 nosnibor89 commented Oct 23, 2024

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines (TBH yarn run contract-tests failed for me even in main)
  • I have validated my changes against all supported platform versions

Related issues

No issue

Describe the solution you've provided

Introducing the new @launchdarkly/svelte-client-sdk package. Some of the details included in this PR are

  1. Svelte Library Boilerplate
  2. Basic Svelte SDK functionality:
    2.1 LDProvider component
    2.2 LDFlag component
    2.3 Svelte-compatible LD instance (exposes API to work with feature flags)

Describe alternatives you've considered

I don't know what to write here.

Additional context

This is the first of a series of PRs. Some of the following PR should be about

  1. Adding Documentation for @launchdarkly/svelte-client-sdk
  2. Adding Example project that uses @launchdarkly/svelte-client-sdk

@nosnibor89 nosnibor89 changed the title add initial SDK library boilerplate and basic svelte LD SDK feat: add initial SDK library boilerplate and basic svelte LD SDK Oct 23, 2024
@nosnibor89 nosnibor89 marked this pull request as ready for review October 23, 2024 21:50
@nosnibor89 nosnibor89 requested a review from a team as a code owner October 23, 2024 21:50
@kinyoklion
Copy link
Member

Hello @nosnibor89,

Thank you for the contribution.

Those contract tests aren't relevant to client-side SDKs, but they should all work correctly (and do run in CI and passed for your PR). When developing locally running yarn build in the root of the repo should get everything into a functioning state. (Builds all packages, and everything in the workspace will use local packages.) The contract tests do run a go binary downloaded from github, so that could cause problems for some configurations.

I won't be able to review this deeply this week, but hopefully I can next week.

Thank you,
Ryan

@kinyoklion kinyoklion merged commit 897905b into launchdarkly:main Dec 19, 2024
22 checks passed
@nosnibor89
Copy link
Contributor Author

Awesome @kinyoklion . Thanks for improving and merging this one.

Next, we'll create PR for "example" project and improve documentation.

@nosnibor89 nosnibor89 deleted the feat/svelte-sdk branch December 19, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants