-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add initial SDK library boilerplate and basic svelte LD SDK #632
Conversation
Hello @nosnibor89, Thank you for the contribution. Those contract tests aren't relevant to client-side SDKs, but they should all work correctly (and do run in CI and passed for your PR). When developing locally running I won't be able to review this deeply this week, but hopefully I can next week. Thank you, |
packages/sdk/svelte/__tests__/lib/client/SvelteLDClient.test.ts
Outdated
Show resolved
Hide resolved
intial refactor to use new "@launchdarkly/js-client-sdk"
…improve initialization logic
[refactor] Update SvelteLDClient to use proxy for flag variations. Allows to track flag evaluations
…js-core into feat/svelte-sdk
…ization with user context
…ents refactor: update SvelteLDClient to use compat SDK and improve initial…
Awesome @kinyoklion . Thanks for improving and merging this one. Next, we'll create PR for "example" project and improve documentation. |
Requirements
yarn run contract-tests
failed for me even inmain
)Related issues
No issue
Describe the solution you've provided
Introducing the new
@launchdarkly/svelte-client-sdk
package. Some of the details included in this PR are2.1
LDProvider
component2.2
LDFlag
component2.3 Svelte-compatible LD instance (exposes API to work with feature flags)
Describe alternatives you've considered
I don't know what to write here.
Additional context
This is the first of a series of PRs. Some of the following PR should be about
@launchdarkly/svelte-client-sdk