Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable brc-20 sends, ref leather-io/issues#5773 #5804

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

pete-watters
Copy link
Contributor

@pete-watters pete-watters commented Aug 22, 2024

Try out Leather build d1f2d93Extension build, Test report, Storybook, Chromatic

This PR marks BRC-20 tokens as readOnly in the AssetList to prevent them being sent

@pete-watters pete-watters linked an issue Aug 22, 2024 that may be closed by this pull request
@alter-eggo
Copy link
Contributor

I'd add this to config

@pete-watters
Copy link
Contributor Author

I'd add this to config

Thanks! I'll close this and assign you the task.

@alter-eggo
Copy link
Contributor

@pete-watters I've meant "it would be better to add to config" as we prob will want this in future.
not like I am going to do it.

@pete-watters pete-watters reopened this Aug 22, 2024
@pete-watters
Copy link
Contributor Author

@pete-watters I've meant "it would be better to add to config" as we prob will want this in future. not like I am going to do it.

OK. I'll add it to the config myself

@pete-watters pete-watters marked this pull request as draft August 22, 2024 13:55
@pete-watters pete-watters force-pushed the chore/5773/disable-brc20-send branch 2 times, most recently from 2195048 to 38deafd Compare August 26, 2024 08:51
@pete-watters
Copy link
Contributor Author

I added a hook to the mono-repo leather-io/mono#395 so that we can toggle this via config

@pete-watters pete-watters marked this pull request as ready for review August 26, 2024 09:01
@pete-watters
Copy link
Contributor Author

leather-io/mono#395

I added a hook for this here but the more I looked into it I realised it doesn't make sense.

We just want to disable send of these assets, not viewing them. The remote configs we use is for totally disabling things usually.

When I checked the AssetList we already have a pattern in place of flagging other assets as isReadOnly so I don't think we should use a config setting here

@pete-watters pete-watters added this pull request to the merge queue Aug 27, 2024
Merged via the queue into dev with commit bcc40f7 Aug 27, 2024
30 checks passed
@pete-watters pete-watters deleted the chore/5773/disable-brc20-send branch August 27, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display BRC20 on Leather with Ledger device Disable BRC-20 sends
3 participants