Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable BRC-20 sends #5773

Closed
pete-watters opened this issue Aug 16, 2024 · 5 comments · Fixed by #5804 or #5817
Closed

Disable BRC-20 sends #5773

pete-watters opened this issue Aug 16, 2024 · 5 comments · Fixed by #5804 or #5817
Assignees
@pete-watters
Labels
area:brc20 area:send effort:small Expected to take up to 1 day of integration work enhancement enhancement-p4 Non-critical functionality wanted by few users, or there are clear alternatives sprint:2024-08-26
Milestone
Fix urgent bugs

Comments

@pete-watters
Copy link
Contributor

The BRC-20 form crashes with TypeError: sum.amount.lt is not a function if you initiate a send then try to go back to the amount input form.

  • Go to Send -> BRC-20,
  • enter some amount and continue to the Choose fee screen
  • hit the back arrow in the top navigation
  • the application crashes

Stacktrace:

TypeError: sum.amount.lt is not a function
    at formatInsufficientBalanceError (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/index.js:6790:43)
    at tokenAmountValidator (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/index.js:20037:14)
    at useBrc20SendForm (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/index.js:20106:85)
    at Brc20SendForm (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/index.js:20159:97)
brc20.mp4
@pete-watters pete-watters added the bug-p2 Critical functionality broken for few users, with no clear workarounds label Aug 16, 2024
@pete-watters pete-watters added this to the Fix urgent bugs milestone Aug 16, 2024
@kyranjamie
Copy link
Collaborator

Think you missed the discussion @pete-watters but plan is to remove BRC-20 send support entirely. It's hardly used.

@pete-watters
Copy link
Contributor Author

Think you missed the discussion @pete-watters but plan is to remove BRC-20 send support entirely. It's hardly used.

I did, thanks! I can close this off

@markmhendrickson markmhendrickson changed the title BRC-20 Send form crashes navigating back from Choose fee Disable BRC-20 sends Aug 22, 2024
@markmhendrickson
Copy link
Collaborator

I'm reopening to tackle the disabling of these sends. We can simply remove BRC-20 tokens from the token selector view during the send flow for now, and come back later to either re-add support or guidance for how users can otherwise send them via apps.

@markmhendrickson markmhendrickson added enhancement-p4 Non-critical functionality wanted by few users, or there are clear alternatives area:send area:brc20 enhancement and removed bug-p2 Critical functionality broken for few users, with no clear workarounds labels Aug 22, 2024
This was referenced Aug 22, 2024
Closed
Closed
Closed
@pete-watters pete-watters self-assigned this Aug 22, 2024
@pete-watters pete-watters linked a pull request Aug 22, 2024 that will close this issue
fix: disable brc-20 sends, ref leather-io/issues#5773 #5804
Merged
@pete-watters
Copy link
Contributor Author

Thanks @markmhendrickson . Disabling BRC-20 sends is straightforward and I have a PR open here for it

@pete-watters
Copy link
Contributor Author

I will enable visibility on Ledger while I am at it #5797

@pete-watters pete-watters mentioned this issue Aug 26, 2024
Closed
@pete-watters pete-watters linked a pull request Aug 26, 2024 that will close this issue
fix: add config hook to disable brc-20 sends, ref leather-io/issues#5773 leather-io/mono#395
Closed
@pete-watters pete-watters added the effort:small Expected to take up to 1 day of integration work label Aug 26, 2024
@pete-watters pete-watters mentioned this issue Aug 28, 2024
Merged
@pete-watters pete-watters linked a pull request Aug 28, 2024 that will close this issue
release: overconfident-bison #5817
Merged
kyranjamie pushed a commit that referenced this issue Aug 28, 2024
@semantic-release-bot
chore(release): 6.47.0
91dc5bc 
## [6.47.0](v6.46.0...v6.47.0) (2024-08-28)

### Features

* add link and unlink mono script ([29f2174](29f2174))
* add mono link ui script ([717737c](717737c))
* mock hiro ft requests ([6987609](6987609))
* mock nfts and txs hiro requests ([318378d](318378d))

### Bug Fixes

* disable brc-20 sends, ref leather-io/issues[#5773](#5773) ([aafd992](aafd992))
* rename dialog as sheet, closes ref leather-io/issues[#268](#268) ([ec64755](ec64755))

### Internal

* add open API, ref leather-io/issues[#5800](#5800) ([3df62f7](3df62f7))
* icons using ui lib svgs, closes leather-io/issues[#123](#123) ([3e8314e](3e8314e))
* post-release merge back ([56d021b](56d021b))
* show BRC-20 tokens on ledger, ref [#5797](#5797) ([bcc40f7](bcc40f7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pete-watters pete-watters

Labels
area:brc20 area:send effort:small Expected to take up to 1 day of integration work enhancement enhancement-p4 Non-critical functionality wanted by few users, or there are clear alternatives sprint:2024-08-26
Projects
None yet
Milestone
Fix urgent bugs
4 participants
@markmhendrickson @kyranjamie @pete-watters @alter-eggo