Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add config hook to disable brc-20 sends, ref leather-io/issues#5773 #395

Closed
wants to merge 1 commit into from

Conversation

pete-watters
Copy link
Contributor

@pete-watters pete-watters commented Aug 26, 2024

This PR adds a config hook so that we will be able to remotely enable / disable BRC-20 sends

leather-io/extension#5773

@pete-watters
Copy link
Contributor Author

I'm not sure if it makes sense to add this as we don't do this to stop send of other assets e.g. SIP-10, SRC-20 etc.

See here

@fbwoolf
Copy link
Contributor

fbwoolf commented Aug 26, 2024

Do we need to be able to toggle this on/off quickly w/out a release? That is the benefit of using the config.

@pete-watters
Copy link
Contributor Author

Do we need to be able to toggle this on/off quickly w/out a release? That is the benefit of using the config.

I don't think so as there are some in BRC-20 send anyway with the form crashing sometimes so we want to just make it ready only.

@alter-eggo suggested using a config setting here but when I looked into it, we already have a pattern of using isReadOnly in the AssetList to disable Send.

I can right more code so that we can toggle it with a setting in the future but we seem to only do that to totally disable / enable things like - runesEnabled , swapEnabled etc.

@fbwoolf
Copy link
Contributor

fbwoolf commented Aug 27, 2024

I can right more code so that we can toggle it with a setting in the future but we seem to only do that to totally disable / enable things like - runesEnabled , swapEnabled etc.

Yeah, I would only add it to the config if it's something we need to control easily w/out doing a release.

@pete-watters
Copy link
Contributor Author

I can right more code so that we can toggle it with a setting in the future but we seem to only do that to totally disable / enable things like - runesEnabled , swapEnabled etc.

Yeah, I would only add it to the config if it's something we need to control easily w/out doing a release.

I don't think we need to do that so I will close this PR and I have removed the config settings from https://github.com/leather-io/extension/pull/5804/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable BRC-20 sends
3 participants