Add error messages for interrupt #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
The error should be an enum if anything, not a |
|
Fixed, all tests pass with |
dvdplm
reviewed
Dec 4, 2018
ghost
assigned
dvdplm
suggested changes
Dec 4, 2018
core/src/nodes/collection.rs
Outdated
| pub enum InterruptErr { | ||
| /// The task entry is vacant; it needs to be added first via add_reach_attempt | ||
| /// (with the TaskState set to Pending) before we try to connect. | ||
| VacantEntry, |
There was a problem hiding this comment.
While it is technically correct that the problem is the entry in the hashmap being vacant, the real error is that they're trying to interrupt using an invalid reach attempt. I think this error variant should reflect that. How about NoSuchReachAttemptId? or just ReachAttemptNotFound?
…hub.com/jamesray1/rust-libp2p into fix/collection-interrupt-error-messages
Co-Authored-By: jamesray1 <16969914+jamesray1@users.noreply.github.com>
…hub.com/jamesray1/rust-libp2p into fix/collection-interrupt-error-messages
…hub.com/jamesray1/rust-libp2p into fix/collection-interrupt-error-messages
dvdplm
suggested changes
Dec 5, 2018
dvdplm
approved these changes
Dec 5, 2018
|
@tomaka can you give this a once-over at your convenience? |
tomaka
approved these changes
Dec 5, 2018
dvdplm
added a commit
to dvdplm/rust-libp2p
that referenced
this pull request
Dec 6, 2018
* upstream/master: Rename all the network behaviours to more basic names (libp2p#726) Avoid some warnings. (libp2p#733) Add error messages for interrupt (libp2p#704) Remove relay, peerstore and datastore (libp2p#723) Don't add an address to the topology if it is already in (libp2p#724) Add a few more methods to Swarm and PollParameters (libp2p#721) Some changes to the main libp2p doc (libp2p#710) Don't wrap yamux::Connection in a mutex (libp2p#719) relay: Use `SliceRandom::shuffle`. (libp2p#722) Remove some boxed futures. (libp2p#718) Fix several errors reported by clippy. (libp2p#715)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.