Don't wrap yamux::Connection in a mutex #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
twittner
approved these changes
Dec 3, 2018
tomaka
reviewed
Dec 4, 2018
|
Yamux 0.1.1 is published. |
tomaka
suggested changes
Dec 4, 2018
Co-Authored-By: dvdplm <dvdplm@gmail.com>
tomaka
approved these changes
Dec 4, 2018
dvdplm
added a commit
to dvdplm/rust-libp2p
that referenced
this pull request
Dec 6, 2018
* upstream/master: Rename all the network behaviours to more basic names (libp2p#726) Avoid some warnings. (libp2p#733) Add error messages for interrupt (libp2p#704) Remove relay, peerstore and datastore (libp2p#723) Don't add an address to the topology if it is already in (libp2p#724) Add a few more methods to Swarm and PollParameters (libp2p#721) Some changes to the main libp2p doc (libp2p#710) Don't wrap yamux::Connection in a mutex (libp2p#719) relay: Use `SliceRandom::shuffle`. (libp2p#722) Remove some boxed futures. (libp2p#718) Fix several errors reported by clippy. (libp2p#715)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the need for an extra mutex. Requires libp2p/rust-yamux#24 for tests to pass.