Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid some warnings. #733

Merged
merged 2 commits into from
Dec 5, 2018
Merged

Avoid some warnings. #733

merged 2 commits into from
Dec 5, 2018

Conversation

twittner
Copy link
Contributor

@twittner twittner commented Dec 5, 2018

  • mdns: unused Result which must be used
  • kad: unused import
  • mplex: use of deprecated item

- mdns: unused `Result` which must be used
- kad: unused import
- mplex: use of deprecated item
@ghost ghost assigned twittner Dec 5, 2018
@ghost ghost added the in progress label Dec 5, 2018
@ghost ghost assigned tomaka Dec 5, 2018
@tomaka tomaka merged commit 4140047 into libp2p:master Dec 5, 2018
@ghost ghost removed the in progress label Dec 5, 2018
@twittner twittner deleted the less-warnings branch December 5, 2018 14:25
@jamesray1
Copy link
Contributor

Thanks!

dvdplm added a commit to dvdplm/rust-libp2p that referenced this pull request Dec 6, 2018
* upstream/master:
  Rename all the network behaviours to more basic names (libp2p#726)
  Avoid some warnings. (libp2p#733)
  Add error messages for interrupt (libp2p#704)
  Remove relay, peerstore and datastore (libp2p#723)
  Don't add an address to the topology if it is already in (libp2p#724)
  Add a few more methods to Swarm and PollParameters (libp2p#721)
  Some changes to the main libp2p doc (libp2p#710)
  Don't wrap yamux::Connection in a mutex (libp2p#719)
  relay: Use `SliceRandom::shuffle`. (libp2p#722)
  Remove some boxed futures. (libp2p#718)
  Fix several errors reported by clippy. (libp2p#715)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants