Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf/js-libp2p: Expected to receive 104857600 bytes, but received 48693248 #291

Closed
mxinden opened this issue Sep 1, 2023 · 2 comments · Fixed by #299
Closed

perf/js-libp2p: Expected to receive 104857600 bytes, but received 48693248 #291

mxinden opened this issue Sep 1, 2023 · 2 comments · Fixed by #299

Comments

@mxinden
Copy link
Member

mxinden commented Sep 1, 2023 •
edited
Loading

Tracking js-libp2p perf failure here:

= Benchmark Single Connection throughput – Download 100 MiB

[ ... ]

== Version js-libp2p/v0.46
=== Starting server js-libp2p/v0.46


=== Starting client js-libp2p/v0.46/tcp
Error: Expected to receive 104857600 bytes, but received 48693248
    at DefaultPerfService.measurePerformance (file:///home/ec2-user/impl/js-libp2p/v0.46/js-libp2p-protocol-perf/node_modules/@libp2p/perf/dist/src/index.js:132:23)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async main (file:///home/ec2-user/impl/js-libp2p/v0.46/js-libp2p-protocol-perf/node_modules/@libp2p/perf/dist/src/main.js:81:26)
./impl/js-libp2p/v0.46/perf: line 6: kill: (54159) - No such process
Error: Expected to receive 104857600 bytes, but received 45744128
    at DefaultPerfService.measurePerformance (file:///home/ec2-user/impl/js-libp2p/v0.46/js-libp2p-protocol-perf/node_modules/@libp2p/perf/dist/src/index.js:132:23)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async main (file:///home/ec2-user/impl/js-libp2p/v0.46/js-libp2p-protocol-perf/node_modules/@libp2p/perf/dist/src/main.js:81:26)
./impl/js-libp2p/v0.46/perf: line 6: kill: (54174) - No such process
Error: Expected to receive 104857600 bytes, but received 44040192
    at DefaultPerfService.measurePerformance (file:///home/ec2-user/impl/js-libp2p/v0.46/js-libp2p-protocol-perf/node_modules/@libp2p/perf/dist/src/index.js:132:23)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async main (file:///home/ec2-user/impl/js-libp2p/v0.46/js-libp2p-protocol-perf/node_modules/@libp2p/perf/dist/src/main.js:81:26)
./impl/js-libp2p/v0.46/perf: line 6: kill: (54191) - No such process
Error: Expected to receive 104857600 bytes, but received 45023232
    at DefaultPerfService.measurePerformance (file:///home/ec2-user/impl/js-libp2p/v0.46/js-libp2p-protocol-perf/node_modules/@libp2p/perf/dist/src/index.js:132:23)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async main (file:///home/ec2-user/impl/js-libp2p/v0.46/js-libp2p-protocol-perf/node_modules/@libp2p/perf/dist/src/main.js:81:26)
./impl/js-libp2p/v0.46/perf: line 6: kill: (54262) - No such process
Error: Expected to receive 104857600 bytes, but received 44498944
    at DefaultPerfService.measurePerformance (file:///home/ec2-user/impl/js-libp2p/v0.46/js-libp2p-protocol-perf/node_modules/@libp2p/perf/dist/src/index.js:132:23)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async main (file:///home/ec2-user/impl/js-libp2p/v0.46/js-libp2p-protocol-perf/node_modules/@libp2p/perf/dist/src/main.js:81:26)
./impl/js-libp2p/v0.46/perf: line 6: kill: (54278) - No such process
Error: Expected to receive 104857600 bytes, but received 45809664
    at DefaultPerfService.measurePerformance (file:///home/ec2-user/impl/js-libp2p/v0.46/js-libp2p-protocol-perf/node_modules/@libp2p/perf/dist/src/index.js:132:23)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async main (file:///home/ec2-user/impl/js-libp2p/v0.46/js-libp2p-protocol-perf/node_modules/@libp2p/perf/dist/src/main.js:81:26)
./impl/js-libp2p/v0.46/perf: line 6: kill: (54293) - No such process
Error: Expected to receive 104857600 bytes, but received 46858240
    at DefaultPerfService.measurePerformance (file:///home/ec2-user/impl/js-libp2p/v0.46/js-libp2p-protocol-perf/node_modules/@libp2p/perf/dist/src/index.js:132:23)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async main (file:///home/ec2-user/impl/js-libp2p/v0.46/js-libp2p-protocol-perf/node_modules/@libp2p/perf/dist/src/main.js:81:26)
./impl/js-libp2p/v0.46/perf: line 6: kill: (54309) - No such process
Error: Expected to receive 104857600 bytes, but received 47251456
    at DefaultPerfService.measurePerformance (file:///home/ec2-user/impl/js-libp2p/v0.46/js-libp2p-protocol-perf/node_modules/@libp2p/perf/dist/src/index.js:132:23)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async main (file:///home/ec2-user/impl/js-libp2p/v0.46/js-libp2p-protocol-perf/node_modules/@libp2p/perf/dist/src/main.js:81:26)
./impl/js-libp2p/v0.46/perf: line 6: kill: (54380) - No such process
Error: Expected to receive 104857600 bytes, but received 45154304
    at DefaultPerfService.measurePerformance (file:///home/ec2-user/impl/js-libp2p/v0.46/js-libp2p-protocol-perf/node_modules/@libp2p/perf/dist/src/index.js:132:23)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async main (file:///home/ec2-user/impl/js-libp2p/v0.46/js-libp2p-protocol-perf/node_modules/@libp2p/perf/dist/src/main.js:81:26)
./impl/js-libp2p/v0.46/perf: line 6: kill: (54396) - No such process
Error: Expected to receive 104857600 bytes, but received 44630016
    at DefaultPerfService.measurePerformance (file:///home/ec2-user/impl/js-libp2p/v0.46/js-libp2p-protocol-perf/node_modules/@libp2p/perf/dist/src/index.js:132:23)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async main (file:///home/ec2-user/impl/js-libp2p/v0.46/js-libp2p-protocol-perf/node_modules/@libp2p/perf/dist/src/main.js:81:26)
./impl/js-libp2p/v0.46/perf: line 6: kill: (54411) - No such process
Command failed: ssh -o StrictHostKeyChecking=no ec2-user@1.2.3.4 'for i in {1..10}; do ./impl/js-libp2p/v0.46/perf --server-address 1.2.3.4:4001 --transport tcp --upload-bytes 0 --download-bytes 104857600; done'
Error: Process completed with exit code 1.

https://github.com/libp2p/test-plans/actions/runs/6048547493/job/16414112311
@mxinden
Copy link
Member Author

mxinden commented Sep 1, 2023

The above error appears consistently across pull requests, when run manually and on master.

@maschad do you have an idea what is happening here?

I will revert #244 for now to unblock pull requests.

mxinden added a commit that referenced this issue Sep 1, 2023
@mxinden
Revert "feat(perf): add js-libp2p NodeJS (#244)"
3b42401 
This reverts commit c39bfb9.

Reverting due to #291. Can revert
revert once resolved.
@mxinden mxinden mentioned this issue Sep 1, 2023
Merged
mxinden added a commit that referenced this issue Sep 1, 2023
@mxinden
Revert "feat(perf): add js-libp2p NodeJS (#244)" (#292)
a68c196 
This reverts commit c39bfb9.

Reverting due to #291. Can revert
revert once resolved.
@mxinden mxinden mentioned this issue Sep 4, 2023
Closed
@maschad
Copy link
Member

maschad commented Sep 4, 2023

I am investigating this, it may be related to libp2p/js-libp2p#2020 but not sure yet.

@mxinden mxinden mentioned this issue Sep 6, 2023
Closed
maschad added a commit to maschad/test-plans that referenced this issue Sep 6, 2023
@maschad
fix: upgrade @libp2p/perf package to use noise + fix stream closing i…
8b6e0e2 
…ssue (libp2p#291)
This was referenced Sep 6, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mxinden @maschad