Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(perf): re-introduce js-libp2p perf + add encryption #299

Merged
merged 5 commits into from
Sep 14, 2023

Conversation

maschad
Copy link
Member

@maschad maschad commented Sep 6, 2023

Closes #291

Also adds noise encryption

Related libp2p/js-libp2p#1991

@maschad
Copy link
Member Author

maschad commented Sep 7, 2023

I've ran this with local infra successfully a few times @mxinden @p-shahi would you be able to trigger a perf run for this on ci?

@p-shahi
Copy link
Member

p-shahi commented Sep 7, 2023

@p-shahi
Copy link
Member

p-shahi commented Sep 7, 2023

https://github.com/libp2p/test-plans/actions/runs/6115444274

@maschad the perf run is continuously printing
./impl/js-libp2p/v0.46/perf: line 6: kill: (65610) - No such process

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for the work!

perf/runner/terraform.tfstate Outdated Show resolved Hide resolved
perf/terraform/configs/local/.terraform.lock.hcl Outdated Show resolved Hide resolved
@mxinden
Copy link
Member

mxinden commented Sep 8, 2023

@maschad the perf run is continuously printing ./impl/js-libp2p/v0.46/perf: line 6: kill: (65610) - No such process

That should be fine as long as the server is able to bind to the provided port and the client is able to connect to it.

@maschad maschad requested a review from mxinden September 8, 2023 15:23
@mxinden
Copy link
Member

mxinden commented Sep 14, 2023

Thank you for the follow-ups. Triggered a new workflow:

https://github.com/libp2p/test-plans/actions/runs/6187524479/job/16797554461

@mxinden mxinden merged commit a96d930 into libp2p:master Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

perf/js-libp2p: Expected to receive 104857600 bytes, but received 48693248
3 participants