[admin-tool][controller] Add new config into ZK and allow admin-tool to update the config #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minhmo1620
force-pushed
the
admin_tool/add_protocol_version_command
branch
from
dfade0e to
f1479e6
Compare
2 tasks
minhmo1620
commented
Feb 11, 2025
...controller/src/main/java/com/linkedin/venice/controller/server/AdminTopicMetadataRoutes.java
Outdated
Show resolved
Hide resolved
minhmo1620
commented
Feb 11, 2025
...oller/src/main/java/com/linkedin/venice/controller/server/ClusterAdminOpsRequestHandler.java
Outdated
Show resolved
Hide resolved
added 10 commits
February 11, 2025 16:45
minhmo1620
force-pushed
the
admin_tool/add_protocol_version_command
branch
from
fd77b1d to
b5f01d7
Compare
minhmo1620
force-pushed
the
admin_tool/add_protocol_version_command
branch
from
b5f01d7 to
1bf784b
Compare
huangminchn
requested changes
Feb 12, 2025
clients/venice-admin-tool/src/test/java/com/linkedin/venice/TestAdminTool.java
Outdated
Show resolved
Hide resolved
...nice-controller/src/main/java/com/linkedin/venice/controller/AdminTopicMetadataAccessor.java
Show resolved
Hide resolved
services/venice-controller/src/main/java/com/linkedin/venice/controller/VeniceHelixAdmin.java
Outdated
Show resolved
Hide resolved
...ce-controller/src/main/java/com/linkedin/venice/controller/ZkAdminTopicMetadataAccessor.java
Outdated
Show resolved
Hide resolved
...controller/src/main/java/com/linkedin/venice/controller/server/AdminTopicMetadataRoutes.java
Show resolved
Hide resolved
...st-common/src/integrationTest/java/com/linkedin/venice/controller/TestAdminToolEndToEnd.java
Outdated
Show resolved
Hide resolved
sushantmane
reviewed
Feb 12, 2025
added 6 commits
February 12, 2025 11:19
2 tasks
This was referenced Feb 13, 2025
huangminchn
reviewed
Feb 14, 2025
...ontroller/src/test/java/com/linkedin/venice/controller/TestZkAdminTopicMetadataAccessor.java
Outdated
Show resolved
Hide resolved
huangminchn
approved these changes
Feb 14, 2025
minhmo1620
added a commit
that referenced
this pull request
Feb 18, 2025
#1535) Add grpc endpoint for updateAdminOperationProtocolVersion Input: clusterName, target admin operation version we want to set ( -1 for the latest version) Output: clusterName and updated admin operation version. This PR only contains the gRPC setup for the endpoint, the main logic can be found in PR #1418
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We will introduce a new field in adminTopicMetadata in ZK at cluster-level to store the admin operation version to serialize/deserialize the message.
Why?
Please take a look at the design doc here. This PR is the first step to remove protocol upgrade deployment order. The expectation is that, with the remote protocol version at cluster-level, the deserializer will use the version, which the writer used to serialize AdminOperation, to deserialize the message. We will fail fast if necessary if the schema versions mismatch.
How was this PR tested?
added UTs and integration tests
What's next?
Update the serializer to fetch the version in ZK before serialize the message, and pass over this version for deserializer to deserialize.
Does this PR introduce any user-facing changes?