[admin-tool] Add gRPC endpoint for updateAdminOperationProtocolVersion #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sushantmane
reviewed
Feb 14, 2025
internal/venice-common/src/main/proto/controller/ClusterAdminOpsGrpcService.proto
Outdated
Show resolved
Hide resolved
minhmo1620
force-pushed
the
admin_tool/add_rpc_updateAdminOperationProtocolVersion
branch
3 times, most recently
from
0e03739 to
eb37aa0
Compare
minhmo1620
changed the title
minhmo1620
force-pushed
the
admin_tool/add_rpc_updateAdminOperationProtocolVersion
branch
from
9ad95eb to
fa932b2
Compare
sushantmane
reviewed
Feb 14, 2025
...oller/src/main/java/com/linkedin/venice/controller/server/ClusterAdminOpsRequestHandler.java
Outdated
Show resolved
Hide resolved
huangminchn
reviewed
Feb 14, 2025
...controller/src/main/java/com/linkedin/venice/controller/server/AdminTopicMetadataRoutes.java
Show resolved
Hide resolved
...oller/src/main/java/com/linkedin/venice/controller/server/ClusterAdminOpsRequestHandler.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[admin-tool] Add gRPC endpoint for updateAdminOperationProtocolVersion
Within #1418, we have added the HTTP endpoint for --update-admin-operation-protocol-version in admin-tool to update admin operation protocol version, and we would do the same for gRPC endpoint.
How was this PR tested?
CI
Does this PR introduce any user-facing changes?