Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[protocol] Add gRPC endpoint for updateAdminOperationProtocolVersion in proto #1533

Conversation

minhmo1620
Copy link
Collaborator

[protocol] Add gRPC endpoint for updateAdminOperationProtocolVersion

Within #1418, we have added the HTTP endpoint for --update-admin-operation-protocol-version in admin-tool to update admin operation protocol version, and we would do the same for gRPC endpoint. Due to the CI limitation, we are cutting proto change into this PR. The real implementation will be provided later.

How was this PR tested?

CI

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

@minhmo1620 minhmo1620 marked this pull request as ready for review February 13, 2025 23:16
sushantmane
sushantmane previously approved these changes Feb 13, 2025
Copy link
Collaborator

@sushantmane sushantmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @minhmo1620!

Copy link
Collaborator

@sushantmane sushantmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@minhmo1620 minhmo1620 merged commit 9284547 into linkedin:main Feb 14, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants