fix: [M3-7826] - Display parent email in user menu when no company name is available for restricted parent user

[mjac0bs]

Description 📝

We learned on the backend that company may be null for some users, even if they payByAkamai. (Though awaiting final confirmation that this won't change going forward and can be retroactively applied to parent/child accounts when the relationship made on the backend.) Assuming company can still be null, we won't always be able to display the company under the helper text "You are currently logged in as:" in the user menu dropdown for parent and proxy users.

This PR falls back on username in those cases, so we are no longer rendering an empty string in the UserMenu dropdown and success toast.

UPDATE (3/4): Marked as Do Not Merge and Requires Changes because:

• Product wants us to fall back on email rather than username (pending final confirmation)
  • We'd need to ensure parent email cannot be updated to null
• The child account list in the Switch Account Drawer uses company name; we would also need to replace with email

UPDATE (3/8): Reopening this PR because we found a case where company is not available: when a restricted parent user has the child_account_access grant enabled (and therefore account-switching abilities) but does not have any Billing Access (account_access: null) -- this means that are not authorized to access account/ and retrieve the company.

Changes 🔄

• For a proxy user, we fall back on proxy email rather than parent username + child company if we can’t display the child company name.
• For a parent user, we fall back on parent email if we can’t display the parent company name.
• Updates test coverage in UserMenu.test.tsx to reflect this.

Preview 📷

Before	After

How to test 🧪

Prerequisites

• This can be tested with mocks more easily than in the dev environment because you'd need to ask me for provisioned parent/child account access, then log into alpha admin and delete a child account's company name, and make one manual code edit due to an API bug with child_account_access (the grant isn't being returned correctly) to eliminate the final !isChildAccountAccessRestricted check from const canSwitchBetweenParentOrProxyAccount if you want the Switch Account button to show up.

Reproduction steps

• Look at the diff and notice how this code before was defaulting to company being an empty string if the conditional was false, and then displaying that empty string in the user menu and tooltip.

Verification steps

• Check out this PR and yarn up.
• Ensure the parent/child feature flag is on.
  With mocks:
• Edit the account endpoint here in serverHandlers.ts to return a null company name. Confirm your user_type is parent.
• Open the user menu and confirm the username is visible. Click the Switch Account button and switch into a proxy account by selecting a child.
• Edit the profile endpoint in serverHandlers.ts to have a user_type of proxy.
• Confirm the success toast includes the username.
• Open the user menu and confirm the username is visible.
• (Note that it will be the same username ("mock-user") since mocks will use the same profile endpoint.)

As an Author I have considered 🤔

Check all that apply

• 👀 Doing a self review
• ❔ Our contribution guidelines
• 🤏 Splitting feature into small PRs
• ➕ Adding a changeset
• 🧪 Providing/Improving test coverage
• 🔐 Removing all sensitive information from the code and PR description
• 🚩 Using a feature flag to protect the release
• 👣 Providing comprehensive reproduction steps
• 📑 Providing or updating our documentation
• 🕛 Scheduling a pair reviewing session
• 📱 Providing mobile support
• ♿ Providing accessibility support

[hkhalil-akamai]

Looks good when testing with mocks. Unable to verify account switching toasts.

[mjac0bs]

Closing this PR as it has been determined that we do not need a fallback for companyName. Elsewhere on the backend, we were incorrectly retrieving that data from a value that could be optional. This will be changed on the backend to a value that is required, so the companyName will always exist.

[github-actions]

Coverage Report: ✅
Base Coverage: 81.4%
Current Coverage: 81.4%

[mjac0bs]

For posterity: we reopened this PR after finding an edge case where if a restricted parent account does not have Billing Access but does have child_account_access, we can’t access the account endpoint to grab the company. However, with the enabled grant, they do have account switching access, so we had a blank in the user menu again.

Following guidance from Product, we can fall back on parent email here.

Issue:

Fix:

[mjac0bs]

We received approval on this from Product so I'm going to go ahead and merge this ahead of the demo since it is a bug that otherwise will be visible.