upcoming: [M3-7835] - Adjust user table column count #10252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaalah-akamai
requested review from
jdamore-linode and
carrillo-erik
and removed request for
a team
jaalah-akamai
changed the title
jaalah-akamai
commented
Mar 4, 2024
| const { | ||
| data: proxyUser, | ||
| error: proxyUserError, | ||
| isLoading: isLoadingProxyUser, | ||
| } = useAccountUsers({ | ||
| enabled: flags.parentChildAccountAccess, | ||
| enabled: | ||
| flags.parentChildAccountAccess && showProxyUserTable && !isRestrictedUser, |
There was a problem hiding this comment.
This was previously being run for parent user types when it was never used, and restricted accounts.
|
Coverage Report: ✅ |
mjac0bs
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Thank you for fixing! Definitely on me for not checking all the screen sizes when working with the loading states and # of columns.
Confirmed by blocking network requests to see loading state tables that the columns match up now. Confirmed the right data is fetched and represented in tables depending on the user_type.
carrillo-erik
approved these changes
Mar 5, 2024
|
@jaalah-akamai Quick question.. In the video you posted in the PR description, when you are changing the viewport widths, are you viewing the page in mobile view as well? In other words, are you also activating the mobile view feature within the devtools? |
vrajesh73
added a commit
to vrajesh73/manager
that referenced
this pull request
Mar 12, 2024
…eature/namespace-create * 'develop' of https://github.com/vrajesh73/manager: (89 commits) fix: [M3-7269] - Display parent email in user menu when no company name is available for restricted parent user (linode#10248) fix: [M3-7817] - Show correct status of Child Account Enabled column for parent users (linode#10233) upcoming: [M3-7616] - Add Placement Groups Events and Notifications (linode#10221) upcoming: [M3-7816-v2] - Adjust logic for when to show Switch Account button (linode#10266) fix: [M3-7831] - Persisting error messages in ACLB delete dialogs (linode#10254) upcoming: [M3-7842] - Update Assign Linode Drawer and improve query skipping (linode#10263) upcoming: [M3-7704] - Disable Cloning, Private IP, Backups for edge regions (linode#10222) test: Fix test flake for Images landing page test (linode#10267) fix: [M3-7824] - ACLB TCP Rule Creation and other fixes (linode#10264) refactor: [M3-7687] - Linodes Restricted User Experience 2/2 (linode#10227) test: Resolve OBJ create and delete E2E test flake (linode#10245) upcoming: [M3-7723] - Placement Group feature flag as object (linode#10256) chore(deps): Bump sanitize-html from 2.11.0 to 2.12.1 (linode#10247) change: [M3-7813] - Allow the disabling of the TypeToConfirm input (linode#10251) upcoming: [M3-7839] - Change Business Partner to Parent User (linode#10259) upcoming: [M3-7835] - Adjust user table column count (linode#10252) upcoming: [M3 7738] - Update Placement Group Create & Edit Drawers (linode#10205) refactor: [M3-7437] - Use `@lukemorales/query-key-factory` for Profile Queries (linode#10241) fix: React Query `updateInPaginatedStore` helper function not working as expected (linode#10249) test: [M3-7497] - Add tests for child user verification banner (linode#10204) ... # Conflicts: # packages/manager/src/MainContent.tsx # packages/manager/src/dev-tools/FeatureFlagTool.tsx
This was referenced Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Navigating through different breakpoints in the application, I notice that the loading state columns are misaligned. This inconsistency is particularly noticeable for normal users, parent users with additional "child account access" column, and proxy users where the "last login" column is removed. To enhance the user experience and ensure clarity in data presentation, we need to account for these variations in column arrangement and loading state across breakpoints.
In addition, if the proxy user doesn't have full access - we should disable the query to fetch the proxy user in the table instead of returning "Unauthorized".
Changes 🔄
whiteSpace: 'nowrap'to prevent excessive collapsing as we scale down breakpoints. It's not perfect, but it's much better.Target release date 🗓️
3/18
Preview 📷
fixed.mp4
How to test 🧪
Prerequisites
(How to setup test environment)
proxy || parent || childtrue: https://github.com/linode/manager/blob/develop/packages/manager/src/features/Users/UsersLandingTableBody.tsx#L21Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply