Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-7723] - Placement Group feature flag as object #10256

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Mar 4, 2024

Description 📝

This PR introduces JSON payload for the Placement Group feature.

Changes 🔄

  • Add new flag in Launch Darkly with JSON payload variations (will delete old one once this is merged to production)
  • Apply to flag to codebase
  • Modify Flag Dev Tools to handle JSON object (with enabled key)
  • Update Feature Flag documentation

Preview 📷

Screenshot 2024-03-04 at 12 39 24

How to test 🧪

Verification steps

  • Pull code locally
  • Open Cloud Manager Dev Tools and click on the "Reset to LD default flags" button.
  • Confirm the toggling of the Placement Groups feature flag and other flags (no regression)

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@@ -101,6 +100,7 @@ import {
WithDisplayData,
WithTypesRegionsAndImages,
} from './types';
import { VPCPanel } from './VPCPanel';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a linting change

@abailly-akamai abailly-akamai marked this pull request as ready for review March 5, 2024 20:44
@abailly-akamai abailly-akamai requested a review from a team as a code owner March 5, 2024 20:44
@abailly-akamai abailly-akamai requested review from dwiley-akamai, hkhalil-akamai and jaalah-akamai and removed request for a team March 5, 2024 20:44
Copy link

github-actions bot commented Mar 5, 2024

Coverage Report:
Base Coverage: 81.38%
Current Coverage: 81.38%

Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating docs too 🔥

@carrillo-erik
Copy link
Contributor

After testing out the reset button in the Cloud Manager devtools, I did not notice any regressions. The docs look great as well.

@abailly-akamai abailly-akamai requested a review from mjac0bs March 6, 2024 15:43
@mjac0bs mjac0bs self-requested a review March 6, 2024 16:26
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Reset to LD default flags" button works ✅
Feature flag toggling works as expected ✅

packages/manager/src/dev-tools/FeatureFlagTool.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 🚢

@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Mar 6, 2024
@abailly-akamai abailly-akamai merged commit 89499b3 into linode:develop Mar 6, 2024
17 of 18 checks passed
vrajesh73 added a commit to vrajesh73/manager that referenced this pull request Mar 12, 2024
…eature/namespace-create

* 'develop' of https://github.com/vrajesh73/manager: (89 commits)
  fix: [M3-7269] - Display parent email in user menu when no company name is available for restricted parent user (linode#10248)
  fix: [M3-7817] - Show correct status of Child Account Enabled column for parent users (linode#10233)
  upcoming: [M3-7616] - Add Placement Groups Events and Notifications (linode#10221)
  upcoming: [M3-7816-v2] - Adjust logic for when to show Switch Account button (linode#10266)
  fix: [M3-7831] - Persisting error messages in ACLB delete dialogs (linode#10254)
  upcoming: [M3-7842] - Update Assign Linode Drawer and improve query skipping (linode#10263)
  upcoming: [M3-7704] - Disable Cloning, Private IP, Backups for edge regions (linode#10222)
  test: Fix test flake for Images landing page test (linode#10267)
  fix: [M3-7824] - ACLB TCP Rule Creation and other fixes (linode#10264)
  refactor: [M3-7687] - Linodes Restricted User Experience 2/2 (linode#10227)
  test: Resolve OBJ create and delete E2E test flake (linode#10245)
  upcoming: [M3-7723] - Placement Group feature flag as object (linode#10256)
  chore(deps): Bump sanitize-html from 2.11.0 to 2.12.1 (linode#10247)
  change: [M3-7813] - Allow the disabling of the TypeToConfirm input (linode#10251)
  upcoming: [M3-7839] - Change Business Partner to Parent User (linode#10259)
  upcoming: [M3-7835] - Adjust user table column count (linode#10252)
  upcoming: [M3 7738] - Update Placement Group Create & Edit Drawers (linode#10205)
  refactor: [M3-7437] - Use `@lukemorales/query-key-factory` for Profile Queries (linode#10241)
  fix: React Query `updateInPaginatedStore` helper function not working as expected (linode#10249)
  test: [M3-7497] - Add tests for child user verification banner (linode#10204)
  ...

# Conflicts:
#	packages/manager/src/MainContent.tsx
#	packages/manager/src/dev-tools/FeatureFlagTool.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Placement Groups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants