1.8.x Refactor #338
Open
1.8.x Refactor #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-type-fixes fix: additional strict type fixes
Fix #323 Refactor the alert banner entitiy to use a more standard approach to revisions, using \Drupal\Core\Entity\Routing\RevisionHtmlRouteProvider instead of custom routes, and using standard revsion routes instead of custom versions in routing.yml. This also groups all the none view crud permissions into the manage alert banner permission in alertBannerEntityAccessControlHandler.
Normally not required as the view is in place, but sometimes needed if the view is disabled.
Note: this may still get removed later in the refactor, but for now restore route admin/structure/alert-banner-types
Ref #334 Flaged as deprecated because of the {% spaceless %} tag, which should have been removed with the move to Drupal 9? However this template is simply not used, so removing.
Ref #334 Remove view default_argument_skip_url config key which is being removed. See https://www.drupal.org/node/3382316
Fix #261 Use a new AlertBannerManager service and move the getCurentBanners method from the block to the manager service. Adds an $options array for setting the type and future options. Small refactor to use loadMultiple.
…ctor Initial refactor of revision provider and access
Remove unused add type template
…anager Move getCurrentBanners to a service
Run tests on 1.8.x branch
…fault-argument Remove default_argument_skip_url from group manage alert banners view
Fix #229 Implements hook_gin_content_form_routes for both the alert banner creation and edit form. This makes editing the alert banner like nodes. Renames the publishing options group meta to auto pick up gin theming. Moves the revision log and new revision into the meta group Add a flag if this is the Gin theme, if it is add the extra class to meta so it is themed like nodes.
Fix #342 Use the standard drupal paths (entity_type/manage) for the alert banner entity type routes, and add a local task for the edit link. This restores expected behaviour with edit, fields, manage form, manage display, permissions. Remove unneed entity type route provider and remove todo comment from entity type list builder.
…theme Opt into the Gin content form routes (edit theme)
…entity-type Fix alert banner entity type paths and local tasks
…ermissions-test Fix routes to localgov_alert_banner_types in permissions test
Fix #271 Small refactor to remove the js-cookie dependancy by using native javascript cookie read and write methods.
|
Suggest re rename this branch becuase having a 1.8.x branch seems to be the root of the test failures. |
|
and yet renaming this branch causes this one to pass? |
Remove js-cookie dependancy
Split on `; ` instead of just `;`
Replacing js-cookie functionality with native Javascript.
…-js-cookie Feature: Replace js cookie
* Mark support for Drupal 11 and drop Drupal 9 In main module only. * Mark localgov alert banner full page as Drupal 11 ready js-cookie dependancy removed. * Mark group_alert_banner as supported on Drupal 11 * Update composer.json for Drupal 11 - Set core version as 10 or 11. - Amend the suggestion for localgov_core
* Add access toolbar, view administation theme perms to emergeny publisher role * Add access content overview permission This is so the alert banners menu option is avalible in the toolbar * Remove access administration pages permission from emergency publisher This permission isn't nessecary to access these pages. * Add update hook to grant these permissions * cs: install updates fix * Refactor how some permissions all granted Use a function to install default permissions on install for emergency publisher based on if node or toolbar is installed. Also move the default anon / authenticated users to the set_default_permissions() function. Also only proceed during first install, not on config sync operations. * Add the missing roleInterface
…check [1.8.x] fix: add ignore next line
* Fix todo in admin view functional test to move the admin user creation into the setup function. * Add kernel test to confirm that the admin url for the alert banners is the url set on the page display in the view. * Remove todo comments and redundant line of code. * Tweak comment * Update function comment * Fix coding standards.
…ository) (#369) * Deprecate old constructor signiture of alert banner block This may not be totally nescerry, but to be on the safe side in case the block has been extended, this deprecates the old signiture with current_user and entity.repository and marks alert banner manager as required. * Add the deprecatedProperttTrait to the alert banner block Allows block extensions to still have a currentUser and entityRepository
Fix #247 This provides the details in the readme, will open a new issue for the config option.
See #327. Extends visibility test by providing actual pages for the banner to display on. This also provides an extra banner to test the correct banner is visible per page.
…ble-check Move the visible check to alert banner manager
What does this change?Refactors the Alert banner entity, alert banner block and adds an alert banner manager service. How to test
How can we measure success?Alert banner should function as before, now with Drupal 11 support and the deperacation warnings should be gone. Have we considered potential risks?Check that refactor does not have any side effects. Imagesn/a Accessibilityn/a (follow up PRs to be added in 1.8.1) |
…s-from-drupal-coder-update fix: coding standards introduced by latest drupal coder rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current blockers
Propose we handle in patch release as needs more discussion
Don't know