feat: full android auto support #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Johnny Sørensen <joso@nodes.dk>
* feat: useIsPlaying hook and isPlaying() method * fix: empty line removed at end of file for prettier * fix: added documentation and also updated API to reflect undefined possibilities * fix: account for code review feedback We now return undefined in all cases where the state is uncertain, and we also return both `playing` and `bufferingDuringPlay` from `isPlaying()`.
) * fix(android): foreground issues (close doublesymmetry#2045) - move execution of foregrounding and backgrounding to NotificationState.POSTED in order to avoid race condition where notificationId has not been set yet - avoid comparing to player states that don’t affect foregrounding, by ignoring LOADING, BUFFERING and READY states – all of which can occur both when playing or while paused - also avoid the initial IDLE state, since we are only interested when the player would become idle (i.e. all tracks were removed) - ENDED state should also cause foregrounding to stop (without removing notification) * Fix: Add missing icon to notification (close doublesymmetry#2049) Using `ExoPlayerR.drawable.exo_notification_small_icon` which is exoplayer’s default notification icon.
Call `yarn android:logs` to see all `adb logcat` output from the example app running on android. If the process isn’t started yet, it will wait for it. If the process is restarted, logging will also restart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.