Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Adding Prometheus steps to quickstart #3043

Merged
merged 23 commits into from
Jan 29, 2021
Merged

[DOCS] Adding Prometheus steps to quickstart #3043

merged 23 commits into from
Jan 29, 2021

Conversation

ChrisChinchilla
Copy link
Collaborator

No description provided.

ChrisChinchilla added 4 commits December 22, 2020 16:28
Add prom file text examples
1fb3e70 
Signed-off-by: ChrisChinchilla <chris@chronosphere.io>
Reord include files
d396f90 
Signed-off-by: ChrisChinchilla <chris@chronosphere.io>
Start draft of prometheus getting started content
b62b5c0 
Signed-off-by: ChrisChinchilla <chris@chronosphere.io>
Add steps for query
2eb1d3f 
Signed-off-by: ChrisChinchilla <chris@chronosphere.io>
@ChrisChinchilla ChrisChinchilla marked this pull request as ready for review January 13, 2021 15:39
@codecov
Copy link

codecov bot commented Jan 13, 2021 •
edited
Loading

Codecov Report

Merging #3043 (827796c) into master (e0bc12a) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3043     +/-   ##
=========================================
- Coverage    72.2%    72.2%   -0.1%     
=========================================
  Files        1084     1084             
  Lines      100235   100219     -16     
=========================================
- Hits        72464    72397     -67     
- Misses      22731    22774     +43     
- Partials     5040     5048      +8
Flag Coverage Δ
aggregator 75.8% <0.0%> (-0.1%) ⬇️
cluster 84.8% <0.0%> (ø)
collector 84.3% <0.0%> (ø)
dbnode 78.6% <0.0%> (-0.2%) ⬇️
m3em 74.4% <0.0%> (ø)
m3ninx 73.1% <0.0%> (+<0.1%) ⬆️
metrics 20.0% <0.0%> (ø)
msg 74.2% <0.0%> (+0.1%) ⬆️
query 67.2% <0.0%> (ø)
x 80.3% <0.0%> (-0.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0bc12a...5c6331c. Read the comment docs.

Changes from review
7147803 
Signed-off-by: ChrisChinchilla <chris@chronosphere.io>
benraskin92
benraskin92 approved these changes Jan 26, 2021
View reviewed changes
Copy link
Collaborator

@benraskin92 benraskin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ couple nits

Update Victor theme
489f7be 
Signed-off-by: ChrisChinchilla <chris@chronosphere.io>
@ChrisChinchilla ChrisChinchilla merged commit 922a33b into master Jan 29, 2021
@ChrisChinchilla ChrisChinchilla deleted the chrischinch/quickstart-prom branch January 29, 2021 12:31
soundvibe added a commit that referenced this pull request Jan 29, 2021
@soundvibe
Merge branch 'master' into linasn/bootstrap-profiler
aef0d2c 
* master:
  [dbnode] Add aggregate term limit regression test (#3135)
  [DOCS] Adding Prometheus steps to quickstart (#3043)
  [dbnode] Revert AggregateQuery changes (#3133)
  Fix TestSessionFetchIDs flaky test (#3132)
  [dbnode] Alter multi-segments builder to order by size before processing (#3128)
  [dbnode] Emit aggregate usage metrics (#3123)
  [dbnode] Add Shard.OpenStreamingReader method (#3119)
  [dtests] Docker tests integration with docker-compose (#3031)
  [dbnode] Comments / remove unused var (#3124)
  [query] Handle context.Canceled and map to 499 http status (#3069)
  [dbnode] Use StreamingReadMetadata for bootstrapping (#2938)
  [dbnode] Use DefaultTestOptions in test code (#3113)

# Conflicts:
#	src/dbnode/storage/bootstrap/bootstrapper/fs/source.go
soundvibe added a commit that referenced this pull request Feb 1, 2021
@soundvibe
Merge branch 'master' into linasn/bootstrap-out-of-retention-blocks-fix
8e87325 
* master:
  [dtest] endpoint to fetch tagged (#3138)
  Refactor FetchTagged to return an Iterator of results (#3141)
  [dbnode] Add aggregate term limit regression test (#3135)
  [DOCS] Adding Prometheus steps to quickstart (#3043)
  [dbnode] Revert AggregateQuery changes (#3133)
  Fix TestSessionFetchIDs flaky test (#3132)
  [dbnode] Alter multi-segments builder to order by size before processing (#3128)
  [dbnode] Emit aggregate usage metrics (#3123)
  [dbnode] Add Shard.OpenStreamingReader method (#3119)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benraskin92 benraskin92 benraskin92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisChinchilla @benraskin92