[dbnode] Add aggregate term limit regression test #3135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3135 +/- ##
=========================================
+ Coverage 70.8% 72.3% +1.4%
=========================================
Files 1083 1084 +1
Lines 100219 100236 +17
=========================================
+ Hits 71005 72475 +1470
+ Misses 24139 22726 -1413
+ Partials 5075 5035 -40
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
wesleyk
approved these changes
Jan 29, 2021
| defer ctx.BlockingClose() | ||
|
|
||
| // create initial span from a mock tracer and get ctx | ||
| ctx.SetGoContext(opentracing.ContextWithSpan(stdlibctx.Background(), nil)) |
There was a problem hiding this comment.
ah interesting, why do we need to create a span for the test?
There was a problem hiding this comment.
Ah damn good catch, thought I'd removed this, the test I used as a base did some verification on tracepoints
soundvibe
added a commit
that referenced
this pull request
Jan 29, 2021
* master: [dbnode] Add aggregate term limit regression test (#3135) [DOCS] Adding Prometheus steps to quickstart (#3043) [dbnode] Revert AggregateQuery changes (#3133) Fix TestSessionFetchIDs flaky test (#3132) [dbnode] Alter multi-segments builder to order by size before processing (#3128) [dbnode] Emit aggregate usage metrics (#3123) [dbnode] Add Shard.OpenStreamingReader method (#3119) [dtests] Docker tests integration with docker-compose (#3031) [dbnode] Comments / remove unused var (#3124) [query] Handle context.Canceled and map to 499 http status (#3069) [dbnode] Use StreamingReadMetadata for bootstrapping (#2938) [dbnode] Use DefaultTestOptions in test code (#3113) # Conflicts: # src/dbnode/storage/bootstrap/bootstrapper/fs/source.go
soundvibe
added a commit
that referenced
this pull request
Feb 1, 2021
* master: [dtest] endpoint to fetch tagged (#3138) Refactor FetchTagged to return an Iterator of results (#3141) [dbnode] Add aggregate term limit regression test (#3135) [DOCS] Adding Prometheus steps to quickstart (#3043) [dbnode] Revert AggregateQuery changes (#3133) Fix TestSessionFetchIDs flaky test (#3132) [dbnode] Alter multi-segments builder to order by size before processing (#3128) [dbnode] Emit aggregate usage metrics (#3123) [dbnode] Add Shard.OpenStreamingReader method (#3119)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a regression test to catch the error seen in #3133; also exercises a test case that caused issues on that path (batch limit was unbounded as long as terms remained the same, which caused issues allocing unbounded slices of terms per block of aggregate query)