Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbnode] Revert AggregateQuery changes #3133

Merged
merged 5 commits into from
Jan 28, 2021
Merged

Conversation

arnikola
Copy link
Collaborator

No description provided.

@arnikola arnikola merged commit e0bc12a into master Jan 28, 2021
@arnikola arnikola deleted the arnikola/revert-agg-query branch January 28, 2021 20:01
@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #3133 (f97deda) into master (b973d23) will increase coverage by 0.0%.
The diff coverage is 92.9%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3133   +/-   ##
=======================================
  Coverage    72.2%    72.2%           
=======================================
  Files        1084     1084           
  Lines      100270   100235   -35     
=======================================
+ Hits        72427    72453   +26     
+ Misses      22791    22743   -48     
+ Partials     5052     5039   -13     
Flag Coverage Δ
aggregator 75.9% <ø> (+<0.1%) ⬆️
cluster 84.8% <ø> (+<0.1%) ⬆️
collector 84.3% <ø> (ø)
dbnode 78.7% <92.9%> (+0.1%) ⬆️
m3em 74.4% <ø> (ø)
m3ninx 73.1% <ø> (+<0.1%) ⬆️
metrics 20.0% <ø> (ø)
msg 74.0% <ø> (-0.1%) ⬇️
query 67.2% <ø> (ø)
x 80.3% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b973d23...f97deda. Read the comment docs.

arnikola added a commit that referenced this pull request Jan 29, 2021
soundvibe added a commit that referenced this pull request Jan 29, 2021
* master:
  [dbnode] Add aggregate term limit regression test (#3135)
  [DOCS] Adding Prometheus steps to quickstart (#3043)
  [dbnode] Revert AggregateQuery changes (#3133)
  Fix TestSessionFetchIDs flaky test (#3132)
  [dbnode] Alter multi-segments builder to order by size before processing (#3128)
  [dbnode] Emit aggregate usage metrics (#3123)
  [dbnode] Add Shard.OpenStreamingReader method (#3119)
  [dtests] Docker tests integration with docker-compose (#3031)
  [dbnode] Comments / remove unused var (#3124)
  [query] Handle context.Canceled and map to 499 http status (#3069)
  [dbnode] Use StreamingReadMetadata for bootstrapping (#2938)
  [dbnode] Use DefaultTestOptions in test code (#3113)

# Conflicts:
#	src/dbnode/storage/bootstrap/bootstrapper/fs/source.go
soundvibe added a commit that referenced this pull request Feb 1, 2021
* master:
  [dtest] endpoint to fetch tagged (#3138)
  Refactor FetchTagged to return an Iterator of results (#3141)
  [dbnode] Add aggregate term limit regression test (#3135)
  [DOCS] Adding Prometheus steps to quickstart (#3043)
  [dbnode] Revert AggregateQuery changes (#3133)
  Fix TestSessionFetchIDs flaky test (#3132)
  [dbnode] Alter multi-segments builder to order by size before processing (#3128)
  [dbnode] Emit aggregate usage metrics (#3123)
  [dbnode] Add Shard.OpenStreamingReader method (#3119)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants