🔃 [Magento Community Engineering] Community Contributions - 2.2-develop

Accepted Public Pull Requests: - #22801: [Backport] #21473: Form element validation is not triggered when validation rules� (by @amol2jcommerce) - #22836: [Backport] Fixed:#22395 (by @shikhamis11) Fixed GitHub Issues: - #21473: Form element validation is not triggered when validation rules change (reported by @mam08ixo) has been fixed in #22801 by @amol2jcommerce in 2.2-develop branch Related commits: 1. f9396db 2. 20e3818 - #22395: config:set -le and -lc short form options don't work (reported by @MichaelThessel) has been fixed in #22836 by @shikhamis11 in 2.2-develop branch Related commits: 1. df7fad8 2. 2e7c766
magento · May 17, 2019 · 3c25318 · 3c25318
2 parents 988649e + 169054f
commit 3c25318
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/app/code/Magento/Config/Console/Command/ConfigSetCommand.php b/app/code/Magento/Config/Console/Command/ConfigSetCommand.php
@@ -114,13 +114,13 @@ protected function configure()
                 ),
                 new InputOption(
                     static::OPTION_LOCK_ENV,
-                    'le',
+                    'e',
                     InputOption::VALUE_NONE,
                     'Lock value which prevents modification in the Admin (will be saved in app/etc/env.php)'
                 ),
                 new InputOption(
                     static::OPTION_LOCK_CONFIG,
-                    'lc',
+                    'c',
                     InputOption::VALUE_NONE,
                     'Lock and share value with other installations, prevents modification in the Admin '
                     . '(will be saved in app/etc/config.php)'
@@ -139,8 +139,10 @@ protected function configure()
     /**
      * Creates and run appropriate processor, depending on input options.
      *
-     * {@inheritdoc}
+     * @param InputInterface $input
+     * @param OutputInterface $output
      * @since 100.2.0
+     * @return int|null
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {

diff --git a/app/code/Magento/Ui/view/base/web/js/form/element/abstract.js b/app/code/Magento/Ui/view/base/web/js/form/element/abstract.js
@@ -296,7 +296,7 @@ define([
                 this.validation[rule] = options;
             }
 
-            changed = utils.compare(rules, this.validation).equal;
+            changed = !utils.compare(rules, this.validation).equal;
 
             if (changed) {
                 this.required(!!rules['required-entry']);