Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Success message is not showing when creating invoice & shipment simultaniously #19942

Closed
surabhisrivastava09 opened this issue Dec 22, 2018 · 10 comments
Assignees
Labels
Component: Sales Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@surabhisrivastava09
Copy link
Member

Preconditions (*)

  1. Magento 2.3
  2. PHP 7.1.3

Steps to reproduce (*)

  1. Create order from admin panel.
  2. View order at admin panel and Click "create invoice".
  3. Check the checkbox "create shipment" and "Email copy of invoice" while generating invoice. and click submit invoice button.

Expected result (*)

  1. Success message should show as "You created the invoice and shipment."

Actual result (*)

  1. Invoice has been created but no success message is appearing.
@GovindaSharma GovindaSharma self-assigned this Dec 22, 2018
@magento-engcom-team
Copy link
Contributor

Hi @Surabhi-Cedcoss. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@Surabhi-Cedcoss do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Dec 22, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Dec 22, 2018

Hi @GovindaSharma. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@GovindaSharma GovindaSharma added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Dec 22, 2018
@GovindaSharma
Copy link
Contributor

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @GovindaSharma. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @GovindaSharma, here is your Magento instance.
Admin access: https://i-19942-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@GovindaSharma GovindaSharma added Component: Sales Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Dec 22, 2018
@magento-engcom-team
Copy link
Contributor

@GovindaSharma Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-97300 were created

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Dec 22, 2018
@XxXgeoXxX XxXgeoXxX self-assigned this Jan 17, 2019
@magento-engcom-team
Copy link
Contributor

Hi @XxXgeoXxX. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

XxXgeoXxX added a commit to XxXgeoXxX/magento2 that referenced this issue Jan 18, 2019
@XxXgeoXxX
Copy link
Member

Messages are removed after call method app/code/Magento/Email/Model/Template/Filter.php:blockDirective because all/only shipment email template used construction '{{block}}'. When shipment and invoice created together with send email functionality mesages were added and after that Magento creates block(according templates app/code/Magento/Sales/view/frontend/email/shipment_new.html) by layout functionality(\Magento\Framework\View\LayoutInterface) and it call method initMessages which remove all of them.

This does not happen when we only ship order because method add messages called after send email.

XxXgeoXxX added a commit to XxXgeoXxX/magento2 that referenced this issue Jan 18, 2019
@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jan 29, 2019
@magento-engcom-team
Copy link
Contributor

Hi @Surabhi-Cedcoss. Thank you for your report.
The issue has been fixed in #20142 by @Surabhi-Cedcoss in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.1 release.

magento-engcom-team added a commit that referenced this issue Jan 29, 2019
…reating invoice & shipment simultaniously #20142

 - Merge Pull Request #20142 from Surabhi-Cedcoss/magento2:2.3-develop-pr3
 - Merged commits:
   1. e6c41ba
magento-engcom-team added a commit that referenced this issue Jan 29, 2019
…reating invoice & shipment simultaniously #20142

 - Merge Pull Request #20142 from Surabhi-Cedcoss/magento2:2.3-develop-pr3
 - Merged commits:
   1. e6c41ba
   2. 0689a17
magento-engcom-team pushed a commit that referenced this issue Jan 29, 2019
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Feb 8, 2019
@magento-engcom-team
Copy link
Contributor

Hi @Surabhi-Cedcoss. Thank you for your report.
The issue has been fixed in #20776 by @GovindaSharma in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.9 release.

magento-engcom-team added a commit that referenced this issue Feb 8, 2019
 - Merge Pull Request #20776 from cedcommerce/magento2:govind2.2-DevelopPr1
 - Merged commits:
   1. 0ec113f
   2. a44cb0e
magento-engcom-team added a commit that referenced this issue Mar 11, 2019
…hipment simultaniously #19942 #20391

 - Merge Pull Request #20391 from XxXgeoXxX/magento2:2.3-develop#19942
 - Merged commits:
   1. 32f0eb7
magento-engcom-team added a commit that referenced this issue Mar 11, 2019
Accepted Public Pull Requests:
 - #20391: Success message is not showing when creating invoice & shipment simultaniously #19942 (by @XxXgeoXxX)
 - #21498: Setting default sorting #21493 (by @Jitheesh)
 - #21534: correct spelling (by @ravi-chandra3197)
 - #21536: Fix type hints and replace deprecated method usage (by @avstudnitz)
 - #21509: Fix: Cart is emptied when enter is pressed after changing product quantity (by @lfluvisotto)
 - #20528: Fix for #20527 [Admin] Configurable product variations table cell labels wrong position (by @vasilii-b)
 - #19376: 19276 - Fixed price renderer issue (by @sarfarazbheda)


Fixed GitHub Issues:
 - #21493: Setting default sorting (reported by @iproger) has been fixed in #21498 by @Jitheesh in 2.3-develop branch
   Related commits:
     1. 50647c4

 - #21499: Cart is emptied when enter is pressed after changing product quantity (reported by @wojtekn) has been fixed in #21509 by @lfluvisotto in 2.3-develop branch
   Related commits:
     1. 539766f
     2. fd3344b

 - #20527: [Admin] Configurable product variations table cell labels wrong position (reported by @vasilii-b) has been fixed in #20528 by @vasilii-b in 2.3-develop branch
   Related commits:
     1. af11e87
     2. ed2a80c
     3. d9c962f
     4. e8adeca

 - #19276: Change different product price on selecting different product swatches on category pages (reported by @ankurverma5540) has been fixed in #19376 by @sarfarazbheda in 2.3-develop branch
   Related commits:
     1. 6c5dd94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Sales Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

4 participants