On checkout cart submit, pattern regex validation fails

[vahir2016]

Preconditions (*)

1. Magento ver. 2.2.6

Steps to reproduce (*)

1. On checkout cart page, use input type text for quantity and use pattern like "[0-9]"
2. Bind jquery submit to submit form on input change
3. In broswer console, you will see : "param.test is not a function"
4. The form will not submit

<input id="cart-<?= /* @escapeNotVerified */ $_item->getId() ?>-qty" name="cart[<?= /* @escapeNotVerified */ $_item->getId() ?>][qty]" data-cart-item-id="<?= $block->escapeHtml($_item->getSku()) ?>" value="<?= /* @escapeNotVerified */ $block->getQty() ?>" type="text" size="4" pattern="^(0|[1-9][0-9]*)$" title="<?= $block->escapeHtml(__('Qty')) ?>" class="input-text qty" data-validate="{required:true,'validate-greater-than-zero':true}" data-role="cart-item-qty"/>

require([ 'jquery', ], function($) { $('#form-validate .input-text.qty').on('change', function() { console.log('here'); $('#form-validate').submit(); }); });

Expected result (*)

1. Form submits

Actual result (*)

1. Uncaught TypeError: param.test is not a function
   at $.validator. (validation.js:541)
   at $.validator.check (jquery.validate.js:556)
   at $.validator.checkForm (jquery.validate.js:372)
   at $.validator.form (jquery.validate.js:359)
   at jQuery.fn.init.valid (jquery.validate.js:108)
   at $...isValid (validation.js:1845)
   at $...isValid (jquery-ui.js:402)
   at HTMLFormElement. (jquery-ui.js:494)
   at Function.each (jquery.js:370)
   at jQuery.fn.init.each (jquery.js:137)

I fixed the problem with this solution :
in magento/lib/web/mage/validation.js line 538

replace :

/* eslint-enable max-len */ 'pattern': [ function (value, element, param) { return this.optional(element) || param.test(value); }, $.mage.__('Invalid format.') ],

by
/* eslint-enable max-len */ 'pattern': [ function (value, element, param) { return this.optional(element) || new RegExp(param).test(value); }, $.mage.__('Invalid format.') ],

I am doing a pull request for this.

[m2-assistant]

Hi @vahir2016. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@vahir2016 do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-18258 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[krzksz]

I believe this is fixed by 8488c07