Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show error message when customer click on Add to cart button without selecting atleast one product from recently orderred list #21401

Merged
merged 4 commits into from
Mar 1, 2019
Merged

Show error message when customer click on Add to cart button without selecting atleast one product from recently orderred list #21401

merged 4 commits into from
Mar 1, 2019

Conversation

mageprince
Copy link
Contributor

@mageprince mageprince commented Feb 22, 2019 •
edited
Loading

Description (*)

It should display a proper error message when customer click on Add to cart button without selecting at least one product from the recently ordered list

Fixed Issues (if relevant)

#21398

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mageprince. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@mageprince
Copy link
Contributor Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @mageprince. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @mageprince, here is your new Magento instance.
Admin access: https://pr-21401.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@mageprince
Copy link
Contributor Author

@magento-engcom-team tested in Magento test instance.

@krishprakash krishprakash changed the title Show error message when customer click on Add to cart button without selecting atleast one product from recently orderred list Not show error message when customer click on Add to cart button without selecting atleast one product from recently orderred list Feb 22, 2019
@krishprakash krishprakash changed the title Not show error message when customer click on Add to cart button without selecting atleast one product from recently orderred list Show error message when customer click on Add to cart button without selecting atleast one product from recently orderred list Feb 22, 2019
@rogyar
Copy link
Contributor

rogyar commented Feb 22, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@rogyar rogyar self-assigned this Feb 22, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-21401.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4355 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team mentioned this pull request Mar 1, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit fa95b94 into magento:2.3-develop Mar 1, 2019
@ghost
Copy link

ghost commented Mar 1, 2019

Hi @mageprince, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 1, 2019
@sidolov
ENGCOM-4355: Show error message when customer click on Add to cart bu…
8ec089f 
…tton without selecting atleast one product from recently orderred list #21401
@eduard13 eduard13 mentioned this pull request Mar 1, 2019
Closed
4 tasks
@mageprince mageprince mentioned this pull request Mar 1, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

Labels
Award: bug fix Component: Checkout Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@mageprince @magento-engcom-team @rogyar @nmalevanec