Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport]Show error message if no any product is selected from recent ordered items #21529

Closed

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented Mar 1, 2019

Original Pull Request

#21401

Description (*)

It should display a proper error message when customer click on Add to cart button without selecting at least one product from the recently ordered list

Fixed Issues (if relevant)

  1. Doesn't show any error message when customer click on Add to cart button without selecting atleast one product from recently orderred list #21398: Show error message when customer click on Add to cart button without selecting atleast one product from recently orderred list
  2. ...

Manual testing scenarios (*)

  1. ...
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost
Copy link

ghost commented Mar 1, 2019

@eduard13 unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@magento-engcom-team magento-engcom-team added Component: Checkout Release Line: 2.2 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Mar 1, 2019
@eduard13 eduard13 changed the title Show error message if no any product is selected from recent ordered items [Backport]Show error message if no any product is selected from recent ordered items Mar 1, 2019
@eduard13 eduard13 closed this Mar 1, 2019
@ghost
Copy link

ghost commented Mar 1, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Checkout Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants